Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes: test that classes can implement parameterized ifaces #2288

Closed
catamorphism opened this issue Apr 25, 2012 · 3 comments
Closed

Classes: test that classes can implement parameterized ifaces #2288

catamorphism opened this issue Apr 25, 2012 · 3 comments
Labels
A-typesystem Area: The type system
Milestone
0.4

Comments

@catamorphism
Copy link
Contributor

This probably doesn't work right now.
@ghost ghost assigned catamorphism Apr 25, 2012
catamorphism added a commit that referenced this issue May 7, 2012
@catamorphism
In resolve, visit the path in an iface ref
4f105e4 
Necessary to resolve any type arguments in a ref to a parameterized
iface. This meant that, for example:

class A implements B<int> { ...

didn't work before, because the "int" in B's argument wasn't getting
visited, and thus wasn't getting resolved. Now it works.

Partially addresses Issue #2288, but I also want to check that class
ty params can appear as the type arguments to ifaces (for example,

class A<T> implements B<T> {...

should work.)
catamorphism added a commit that referenced this issue May 7, 2012
@catamorphism
Add another test case for #2288
1e6da7b 
Added a test case for #2288. It's xfailed for now, pending #2364
@catamorphism
Copy link
Contributor Author

Partially addressed in 4f105e4 but the test case in 1e6da7b should pass in order for this to be considered done. #2364 blocks this.

@nikomatsakis
Copy link
Contributor

I found this wasn't really working at all. More-or-less fixed in a3be0b1, probably bugs still remain. @catamorphism I am 99% sure what I did was right, but lemme know if you disagree.

catamorphism added a commit that referenced this issue Jul 13, 2012
@catamorphism
Test for #2288
ee73b78
@catamorphism
Copy link
Contributor Author

This seems to work. Added a test case, closing; open new bugs if there are issues.

@catamorphism catamorphism removed their assignment Jun 16, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2288 - RalfJung:clippy, r=RalfJung
ccfb869 
add ./miri clippy

also make ui_test comply with clippy
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@feliperodri
Avoid undefined behavior in AnySlice::new() (rust-lang#2288)
4b925fd 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-typesystem Area: The type system
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@nikomatsakis @catamorphism