Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The online documentation no longer links to the source #23192

Closed
Thiez opened this issue Mar 8, 2015 · 3 comments · Fixed by #23213
Closed

The online documentation no longer links to the source #23192

Thiez opened this issue Mar 8, 2015 · 3 comments · Fixed by #23213
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Thiez
Copy link
Contributor

Thiez commented Mar 8, 2015

When visiting a page such as stdlib or option the link src (for the source code) no longer works. Instead a 404 is returned. This seems to have been broken for several days now.
@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 8, 2015
@lahwran
Copy link

lahwran commented Mar 8, 2015

even before this, many but not all were broken. there may be multiple issues with this symptom.

@ipetkov
Copy link
Contributor

ipetkov commented Mar 8, 2015

The [src] links link in the form /path/to/src/filename.rs.html but it seems like the actual source is being placed in a location in the form /path/to/src/filename.rs/filename.rs.html

For example here's a link from the current docs which will 404: http://doc.rust-lang.org/src/core/option.rs.html

But the following will resolve: http://doc.rust-lang.org/src/core/option.rs/option.rs.html

@ipetkov ipetkov mentioned this issue Mar 9, 2015
Merged
@dwrensha dwrensha mentioned this issue Mar 9, 2015
Closed
@tbu-
Copy link
Contributor

tbu- commented Mar 10, 2015

Really annoyed by this. :<

@iKevinY iKevinY mentioned this issue Mar 15, 2015
Closed
bors added a commit that referenced this issue Mar 19, 2015
@bors
Auto merge of #23213 - ipetkov:rustdoc-src-fix, r=huonw
81e2396 
* rustdoc was doubly appending the file name to the path of where to
  generate the source files, meanwhile, the [src] hyperlinks were not
* Added a flag to rustdoc::html::render::clean_srcpath to ignore the
  last path component, i.e. the file name itself to prevent the issue
* This also avoids creating directories with the same name as source
  files, and it makes sure the link to `main.css` is correct as well.

Fixes #23192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix [src] hyperlinks in rustdoc
5 participants
@steveklabnik @Thiez @lahwran @ipetkov @tbu-