Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move-out-of-raw-pointer in vec::shift #2703

Closed
graydon opened this issue Jun 21, 2012 · 2 comments
Closed

Move-out-of-raw-pointer in vec::shift #2703

graydon opened this issue Jun 21, 2012 · 2 comments

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

Comment says 'this isn't legal, per se..' which is cute but could do with a bit more explanation of why it's even working.
@nikomatsakis
Copy link
Contributor

Actually I think that's legal now. I recently updated the rules to allow
moves out of unsafe pointers (it's very useful sometimes!)

We were "allowing" it before just because we weren't treating let x <- y
as a move.

@ghost ghost assigned eholk Jun 22, 2012
@eholk
Copy link
Contributor

eholk commented Jun 22, 2012

It's legal now, so I'll remove the comment.

eholk added a commit that referenced this issue Jun 22, 2012
@eholk
Use must_have_lock instead of private functions. (Issue #2700)
26c11f7 
I hereby declare that messages sent from the same source arrive in order (Issue #2605)

Removing FIXME, owned is the correct type here. (Issue #2704)

Remove outdated FIXME (Issue #2703)

Updating test for spawning native functions (Issue #2602)

Removing bogus FIXME (Issue #2599)
@eholk eholk closed this as completed Jun 22, 2012
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @zhassan-aws
Unify Kani bundle CI jobs (rust-lang#2841)
81ec454 
We have two different ways today of building release bundles, one in
`kani.yml` and another one in `release.yml`, and only the `kani.yml`
actually run tests. This is error prone, since the release workflow only
runs during a release without validation tests, and the build can
diverge from what's being tested in CI.

Instead, we will always run the same workflow, except for the steps that
create the release.

Resolves rust-lang#2703

Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graydon @eholk @nikomatsakis