Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of run-make tests on MSVC. #27979

Closed
DiamondLovesYou opened this issue Aug 24, 2015 · 2 comments
Closed

Fix a number of run-make tests on MSVC. #27979

DiamondLovesYou opened this issue Aug 24, 2015 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@DiamondLovesYou
Copy link
Contributor

Due to the way MSYS sandboxes file paths, paths passed to cl.exe are expanded into values which are invalid outside of MSYS.
@steveklabnik steveklabnik added A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows labels Sep 3, 2015
@alexcrichton
Copy link
Member

This was done in #28421

@Eh2406
Copy link
Contributor

Eh2406 commented Sep 3, 2017 •
edited
Loading

There is a FIXME related to this issue,
edit: wrong link.
https://github.com/rust-lang/rust/blob/master/src/test/run-make/no-duplicate-libs/Makefile#L4
Now that the issue is closed can the FIXME be fix, or made more specific?

@oli-obk oli-obk mentioned this issue Sep 6, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @alexcrichton @DiamondLovesYou @Eh2406