Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonparametric dropck (tracking issue for RFC 1238) #28498

Open
1 of 2 tasks
nikomatsakis opened this issue Sep 18, 2015 · 9 comments
Open
1 of 2 tasks

Nonparametric dropck (tracking issue for RFC 1238) #28498

nikomatsakis opened this issue Sep 18, 2015 · 9 comments
Labels
B-RFC-implemented Feature: Approved by a merged RFC and implemented. B-unstable Feature: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. P-medium Medium priority S-tracking-design-concerns Status: There are blocking ❌ design concerns. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 18, 2015 •
edited by pnkfelix

Tracking issue for rust-lang/rfcs#1238.

cc @pnkfelix
@nikomatsakis nikomatsakis added the B-RFC-approved Feature: Approved by a merged RFC but not yet implemented. label Sep 18, 2015
@nikomatsakis
Copy link
Contributor Author

triage: P-high

@rust-highfive rust-highfive added the P-high High priority label Sep 18, 2015
@pnkfelix pnkfelix mentioned this issue Oct 6, 2015
Merged
bors added a commit that referenced this issue Oct 10, 2015
@bors
Auto merge of #28861 - pnkfelix:fsk-nonparam-dropck-issue28498, r=ari…
87cd2c0 
…elb1

implement RFC 1238: nonparametric dropck.

cc #28498 

cc @nikomatsakis
@nikomatsakis
Copy link
Contributor Author

triage: P-medium

@rust-highfive rust-highfive added P-medium Medium priority and removed P-high High priority labels Oct 29, 2015
@alexcrichton
Copy link
Member

I think this was since implemented, so closing (but please reopen if there's something left!)

@SimonSapin
Copy link
Contributor

SimonSapin commented May 4, 2016 •
edited

I think this should be reopened with the B-unstable label. The RFC is implemented, but the #[unsafe_destructor_blind_to_params] attribute is still behind the dropck_parametricity feature gate which points to this as its tracking issue.

#[unsafe_destructor_blind_to_params] is used for Vec and a number of other types defined in the standard library. It isn’t any less useful for types outside the standard library. I’ve needed it for an arena allocator.

@nikomatsakis nikomatsakis added the B-unstable Feature: Implemented in the nightly compiler and unstable. label May 4, 2016
@nikomatsakis
Copy link
Contributor Author

I agree.

@nikomatsakis nikomatsakis reopened this May 4, 2016
@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Aug 19, 2016
@nrc nrc added B-RFC-implemented Feature: Approved by a merged RFC and implemented. and removed B-RFC-approved Feature: Approved by a merged RFC but not yet implemented. labels Aug 29, 2016
@pnkfelix pnkfelix mentioned this issue Oct 10, 2016
Open
7 tasks
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 22, 2017
@steveklabnik
Copy link
Member

Triage: feature gate still active, not aware of any work in this area.

@pnkfelix
Copy link
Member

(i doubt I'm going to be attacking this problem at any point in the foreseeable future. Unassigning self.)

@pnkfelix pnkfelix removed their assignment May 17, 2019
@est31
Copy link
Member

est31 commented Sep 18, 2020

#62568 has removed the feature gate since, but this issue says:

can't close this until we have stable support for 3rd party collection types

@joshtriplett joshtriplett added the S-tracking-design-concerns Status: There are blocking ❌ design concerns. label Nov 10, 2021
@joshtriplett
Copy link
Member

From today's @rust-lang/lang meeting:
The feature seems to be working, but it may need further refinement in order to expose it as stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-implemented Feature: Approved by a merged RFC and implemented. B-unstable Feature: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. P-medium Medium priority S-tracking-design-concerns Status: There are blocking ❌ design concerns. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@steveklabnik @alexcrichton @nikomatsakis @joshtriplett @pnkfelix @SimonSapin @nrc @Mark-Simulacrum @rust-highfive @est31