Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd methods exposing keys of BTreeMap and HashMap entries #32281
Comments
This comment has been minimized.
This comment has been minimized.
|
Was this completed in #32248? |
This comment has been minimized.
This comment has been minimized.
|
@frewsxcv Yes. We'll keep it open as the tracking issue. |
apasel422
added
the
B-unstable
label
Mar 19, 2016
alexcrichton
added
the
T-libs
label
Mar 19, 2016
sfackler
added
the
I-nominated
label
Apr 15, 2016
This comment has been minimized.
This comment has been minimized.
|
Had a use case for this in Diesel this morning. (Code comparison: https://gist.github.com/sgrif/68cbba9a87084da3a2e8c42a12e7d6cf). Worked great, and was exactly the missing piece. Looking forward to seeing this stabilized. |
This comment has been minimized.
This comment has been minimized.
|
I just noticed that while this is on both |
This comment has been minimized.
This comment has been minimized.
|
If I wanted to propose a |
This comment has been minimized.
This comment has been minimized.
|
I think it'd be more associated with the key recovery tracking issue, but that's already landed. In any case, I don't think an RFC would be required - it can piggy back off of the existing key recovery one. |
This comment has been minimized.
This comment has been minimized.
|
cc @aturon |
sfackler
added a commit
to sfackler/rust
that referenced
this issue
Apr 22, 2016
This comment has been minimized.
This comment has been minimized.
|
(including #33148) |
alexcrichton
added
final-comment-period
and removed
I-nominated
labels
Apr 29, 2016
bors
added a commit
that referenced
this issue
Apr 30, 2016
seanmonstar
referenced this issue
Apr 30, 2016
Merged
Map::Entry methods to recover key and value together #33300
This comment has been minimized.
This comment has been minimized.
|
I have effectively the same use-case as @sgrif, +1 from me. |
This comment has been minimized.
This comment has been minimized.
|
The libs team discussed this during triage yesterday and the decision was to stabilize |
dstu commentedMar 16, 2016
As discussed in rfcs, it would make sense to add a
keys()method to theEntryvariants for both map types.PR 32248 has code and tests.