Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for check methods on Duration #35774

Closed
alexcrichton opened this issue Aug 18, 2016 · 7 comments
Closed

Tracking issue for check methods on Duration #35774

alexcrichton opened this issue Aug 18, 2016 · 7 comments
Labels
B-unstable Feature: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#1640
@alexcrichton alexcrichton added B-RFC-approved Feature: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 18, 2016
@alexcrichton alexcrichton mentioned this issue Aug 18, 2016
Merged
@eugene-bulkin
Copy link

eugene-bulkin commented Sep 11, 2016 •
edited

Has anyone taken this on?

EDIT: Some quick questions.

  • What specifically can overflow or fail in div()?
  • Would duration_checked_ops be more appropriate as a feature name?

@alexcrichton
Copy link
Member Author

@eugene-bulkin it's all yours! (I don't think anyone else is currently working on it)

What specifically can overflow or fail in div()?

I believe division by 0 is the only thing to worry about here

Would duration_checked_ops be more appropriate as a feature name?

Certainly! We tend to just pick "whatever name" for library features, we're not too principled about it.

@eugene-bulkin
Copy link

Cool, I'll toss a PR out within the near future!

@eugene-bulkin eugene-bulkin mentioned this issue Sep 14, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 15, 2016
@Manishearth
Rollup merge of rust-lang#36463 - eugene-bulkin:duration-checked-ops,…
ec08128 
… r=alexcrichton

Add checked operation methods to Duration

Addresses rust-lang#35774.
@sfackler sfackler added B-unstable Feature: Implemented in the nightly compiler and unstable. and removed B-RFC-approved Feature: Approved by a merged RFC but not yet implemented. labels Dec 5, 2016
@sfackler
Copy link
Member

sfackler commented Dec 9, 2016

@rfcbot fcp merge

Matches conventions

@rfcbot
Copy link

rfcbot commented Dec 9, 2016 •
edited by brson

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@aturon
Copy link
Member

aturon commented Jan 6, 2017

🔔 This feature is going into its final comment period with disposition to stabilize. 🔔

@aturon aturon added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 6, 2017
@rfcbot
Copy link

rfcbot commented Jan 23, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @sfackler, I wasn't able to add the final-comment-period label, please do so.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 26, 2017
@alexcrichton
std: Stabilize APIs for the 1.16.0 release
671b1c1 
This commit applies the stabilization/deprecations of the 1.16.0 release, as
tracked by the rust-lang/rust issue tracker and the final-comment-period tag.

The following APIs were stabilized:

* `VecDeque::truncate`
* `VecDeque::resize`
* `String::insert_str`
* `Duration::checked_{add,sub,div,mul}`
* `str::replacen`
* `SocketAddr::is_ipv{4,6}`
* `IpAddr::is_ipv{4,6}`
* `str::repeat`
* `Vec::dedup_by`
* `Vec::dedup_by_key`
* `Result::unwrap_or_default`
* `<*const T>::wrapping_offset`
* `<*mut T>::wrapping_offset`
* `CommandExt::creation_flags` (on Windows)
* `File::set_permissions`
* `String::split_off`

The following APIs were deprecated

* `EnumSet` - replaced with other ecosystem abstractions, long since unstable

Closes rust-lang#27788
Closes rust-lang#35553
Closes rust-lang#35774
Closes rust-lang#36436
Closes rust-lang#36949
Closes rust-lang#37079
Closes rust-lang#37087
Closes rust-lang#37516
Closes rust-lang#37827
Closes rust-lang#37916
Closes rust-lang#37966
Closes rust-lang#38080
@alexcrichton alexcrichton mentioned this issue Jan 26, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jan 28, 2017
@alexcrichton
Rollup merge of rust-lang#39307 - alexcrichton:stabilize-1.16, r=brson
0edc3d3 
std: Stabilize APIs for the 1.16.0 release

This commit applies the stabilization/deprecations of the 1.16.0 release, as
tracked by the rust-lang/rust issue tracker and the final-comment-period tag.

The following APIs were stabilized:

* `VecDeque::truncate`
* `VecDeque::resize`
* `String::insert_str`
* `Duration::checked_{add,sub,div,mul}`
* `str::replacen`
* `SocketAddr::is_ipv{4,6}`
* `IpAddr::is_ipv{4,6}`
* `str::repeat`
* `Vec::dedup_by`
* `Vec::dedup_by_key`
* `Result::unwrap_or_default`
* `<*const T>::wrapping_offset`
* `<*mut T>::wrapping_offset`
* `CommandExt::creation_flags` (on Windows)
* `File::set_permissions`
* `String::split_off`

The following APIs were deprecated

* `EnumSet` - replaced with other ecosystem abstractions, long since unstable

Closes rust-lang#27788
Closes rust-lang#35553
Closes rust-lang#35774
Closes rust-lang#36436
Closes rust-lang#36949
Closes rust-lang#37079
Closes rust-lang#37087
Closes rust-lang#37516
Closes rust-lang#37827
Closes rust-lang#37916
Closes rust-lang#37966
Closes rust-lang#38080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Feature: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alexcrichton @aturon @sfackler @eugene-bulkin @rfcbot