Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::net::url's encode and decode should be pure #3782

Closed
erickt opened this issue Oct 16, 2012 · 0 comments
Closed

std::net::url's encode and decode should be pure #3782

erickt opened this issue Oct 16, 2012 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.6

Comments

@erickt
Copy link
Contributor

erickt commented Oct 16, 2012

Right now std::net::url::encode_component is pure, and has to use an unsafe to call std::net::url::encode. We should make that and std::net::url::decode pure. If we don't want to cheat with unsafe blocks, this is blocked on #3758 and #3722.
jesse99 added a commit to jesse99/rust that referenced this issue Nov 17, 2012
@jesse99
Made most of the URL functions pure.
7720531 
This closes rust-lang#3782.
@brson brson closed this as completed in e0805cb Nov 18, 2012
brson pushed a commit that referenced this issue Nov 18, 2012
@jesse99 @brson
Made most of the URL functions pure.
15989ec 
This closes #3782.
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@calebcartwright @topecongiro
don't fail on recoverable parser errors in ignored files (rust-lang#3782
ba4bf03 
)
@rizwan-r-r rizwan-r-r mentioned this issue Apr 2, 2024
Merged
@Kingcrypto38 Kingcrypto38 mentioned this issue Apr 3, 2024
Open
@aravindb26 aravindb26 mentioned this issue Apr 3, 2024
Open
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 5, 2024
@bors
Auto merge of rust-lang#3782 - RalfJung:josh-roundtrip-error, r=RalfJung
9de5630 
when josh-proxy screws up the roundtrip, say what the involved commits are
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@erickt @brson