Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible short-circuit miscompile for while loop guard #3830

Closed
burg opened this issue Oct 22, 2012 · 4 comments
Closed

Possible short-circuit miscompile for while loop guard #3830

burg opened this issue Oct 22, 2012 · 4 comments
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@burg
Copy link

burg commented Oct 22, 2012

In the code linked below, the LHS of an && expression is used as an array bounds guard for the RHS.

This seems to be miscompiled, such that assigning each subexpression to a local inside the loop works fine, but segfaults occur when putting the whole thing as the while condition.

servo/servo@b0536d7

@nikomatsakis
Copy link
Contributor

Have you tried to minimize this into a standalone function?

@burg
Copy link
Author

burg commented Oct 23, 2012

No. I've already spent ~1/2 day bisecting this bug in the last week, and don't have time

On Oct 22, 2012, at 16:41 , Niko Matsakis wrote:

Have you tried to minimize this into a standalone function?


Reply to this email directly or view it on GitHub.

@msullivan
Copy link
Contributor

I'm not really sure what to do with this bug. The comment about the bug is still in servo (in src/components/main/layout/util.rs), but the code has changed so that it doesn't look like I could just switch back to the old version... Played around a bit trying to trigger it with small cases, but didn't find anything.

@thestinger
Copy link
Contributor

Closing due to the lack of a reproducible test case.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Development

No branches or pull requests

4 participants