Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild warning #38484

Closed
est31 opened this issue Dec 20, 2016 · 2 comments
Closed

rustbuild warning #38484

est31 opened this issue Dec 20, 2016 · 2 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@est31
Copy link
Member

est31 commented Dec 20, 2016

When you compile rust you get:

warning: value assigned to `stage` is never read, #[warn(unused_assignments)] on by default
   --> src/bootstrap/flags.rs:277:17
    |
277 |                 stage = Some(1);
    |                 ^^^^^

Regression of #38072

cc @nikomatsakis

Maybe rustbuild should be compiled with #[forbid(warnings)] to prevent errors like these in the future?

@est31
Copy link
Member Author

est31 commented Dec 20, 2016

cc @alexcrichton

@alexcrichton alexcrichton added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 20, 2016
@alexcrichton
Copy link
Member

Yeah when we fix this let's tag rustbuild with #![deny(warnings)]

alexcrichton added a commit to alexcrichton/rust that referenced this issue Dec 20, 2016
Turned out this lint uncovered an actual bug!

Closes rust-lang#38484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants