Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rustdoc main.js to not use jQuery #39159

Closed
clarfonthey opened this issue Jan 18, 2017 · 1 comment
Closed

Refactor rustdoc main.js to not use jQuery #39159

clarfonthey opened this issue Jan 18, 2017 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@clarfonthey
Copy link
Contributor

I took a look at the code and it appears that almost all of the stuff that is implemented in jQuery could be implemented in raw JS with a few extra shims, such that it'd work on virtually all modern browsers. I'd be willing to make these changes but I figured I'd open up an issue to see what people think.

jQuery is kind of big and if a user generates docs for a lot of different crates, it tends to add up.
@clarfonthey
Copy link
Contributor Author

Additional note: I've started some of this but if anyone at any point would like to take over, let me know.

@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 5, 2017
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 15, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue May 5, 2017
@frewsxcv
Rollup merge of rust-lang#41307 - GuillaumeGomez:jquery-removal, r=fr…
31a4d73 
…ewsxcv

Remove jquery dependency

r? @rust-lang/docs

Fixes rust-lang#39159.
@pravic pravic mentioned this issue May 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @sfackler @clarfonthey