Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'note' #415

Closed
graydon opened this issue May 26, 2011 · 7 comments
Closed

Implement 'note' #415

graydon opened this issue May 26, 2011 · 7 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@graydon
Copy link
Contributor

graydon commented May 26, 2011

When unwinding, we should log things marked with 'note' in the unwinding block. Currently we have no support for this, despite excited claims in the manual.
@brson
Copy link
Contributor

brson commented Apr 17, 2012

A simple version of this can probably be implemented with a library function and a macro. @nikomatsakis has been pining for the feature lately.

@catamorphism
Copy link
Contributor

Changing this to an enhancement for doing what @brson suggested as a library.

@14427
Copy link
Contributor

14427 commented Dec 11, 2012

I have written a note macro, although I'm not sure if this is what you had in mind: https://gist.github.com/4262524

@ghost ghost assigned graydon Jan 24, 2013
@thestinger
Copy link
Contributor

D provides this functionality as part of their scope guard support, by allowing you to install them for one of exit, success or failure. Macros for all 3 cases would probably make sense in Rust too.

@pnkfelix
Copy link
Member

Can someone point me at the spec for this? I cannot judge whether the note macro proposed in 14427's comment would suffice.

@catamorphism
Copy link
Contributor

(bug triage) Milestone seems right.

@thestinger
Copy link
Contributor

Replaced with #9835, based on recent movement towards RAII idioms. The ability to run code on success or on exit regardless of failure is useful too.

@graydon graydon removed their assignment Jun 16, 2014
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#415 - kallisti5:master, r=alexcrichton
68abfad 
Haiku: Add in missing build-time types, fix module usage

Working through the few final remaining build issues for the Haiku target.
kazcw pushed a commit to kazcw/rust that referenced this issue Oct 23, 2018
@gnzlbg
Enable fxsr (rust-lang#415)
f750e2a 
Re-enables fxsr
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@matthewjasper
Merge pull request rust-lang#415 from Havvy/no_std
8d7463f 
Document preludes
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this issue Feb 21, 2024
@antoyo
Merge pull request rust-lang#415 from rowan-sl/rename-clean-ui-tests
e747d42 
Rename `y.sh test --clean-ui-tests` to `y.sh clean ui-tests`
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@danielsn @tedinski
Move codegen code out of mod.rs into properly named files (rust-lang#415
5ecadef 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@graydon @brson @pnkfelix @catamorphism @thestinger @14427