Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustbuild doesn't color compiler errors #42801

Closed
Mark-Simulacrum opened this issue Jun 21, 2017 · 0 comments
Closed

Rustbuild doesn't color compiler errors #42801

Mark-Simulacrum opened this issue Jun 21, 2017 · 0 comments
Assignees
@Mark-Simulacrum
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 21, 2017 •
edited

Will investigate -- assigning myself.

cc @alexcrichton
@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 21, 2017
@Mark-Simulacrum Mark-Simulacrum self-assigned this Jun 21, 2017
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 21, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 22, 2017
@frewsxcv
Rollup merge of rust-lang#42804 - Mark-Simulacrum:rustbuild-colors, r…
4a27262 
…=alexcrichton

Make rustc errors colorful.

Rustbuild passes --message-format=json to Cargo to learn about the
dependencies for a given build, which then makes Cargo steal the
stderr/stdout for the compiler process, leading to non colorful output.
To avoid this, detection of stderr being a tty is added to rustbuild,
and an environment variable is used to communicate with the rustc shim.

Fixes rust-lang#42801.

r? @alexcrichton
frewsxcv added a commit to frewsxcv/rust that referenced this issue Jun 22, 2017
@frewsxcv
Rollup merge of rust-lang#42804 - Mark-Simulacrum:rustbuild-colors, r…
595d816 
…=alexcrichton

Make rustc errors colorful.

Rustbuild passes --message-format=json to Cargo to learn about the
dependencies for a given build, which then makes Cargo steal the
stderr/stdout for the compiler process, leading to non colorful output.
To avoid this, detection of stderr being a tty is added to rustbuild,
and an environment variable is used to communicate with the rustc shim.

Fixes rust-lang#42801.

r? @alexcrichton
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 22, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42804 - Mark-Simulacrum:rustbuild-colors, r…
a859f2b 
…=alexcrichton

Make rustc errors colorful.

Rustbuild passes --message-format=json to Cargo to learn about the
dependencies for a given build, which then makes Cargo steal the
stderr/stdout for the compiler process, leading to non colorful output.
To avoid this, detection of stderr being a tty is added to rustbuild,
and an environment variable is used to communicate with the rustc shim.

Fixes rust-lang#42801.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mark-Simulacrum