Wrong "possible better candidate is found in another module" suggestion

[est31]

For this code:

mod foo {
    pub struct B(());
}
mod bar {
    use foo::B;
    fn foo() {
        B(());
    }
}

You get the following error message:

error[E0423]: expected function, found struct `B`
 --> <anon>:7:9
  |
7 |         B(());
  |         ^
  |         |
  |         did you mean `B { /* fields */ }`?
  |         constructor is not visible here due to private fields
  |
help: possible better candidate is found in another module, you can import it into scope
  | use foo::B;

The suggestion may be excused to be not 100% perfect, but here it suggests to add an use statement despite that same item being imported already. What I want is this exactly: that it removes stuff from the suggestion list that is already being imported.

Note that changing the glob import to a non glob one doesn't change anything.

[est31]

cc @estebank

[oli-obk]

Why is that even an error?

[est31]

@oli-obk tuple structs have private fields by default, you can't construct instances of B outside of the foo module.

[oli-obk]

oh ^^ maybe we should simply modify this error message then to say that the "function" is private?

[est31]

It already says "constructor is not visible here due to private fields". That's okay, but maybe you might have meant another B from another module or something. However, the candidate offered is not any better as its the same one you are attempting to use.

[estebank]

Reopening to track "removal of suggestion" work for pub tuple structs with private fields.