A number of tests fails with undefined references to `rust_eh_unwind_resume` when codegen-units > 1 #43095

petrochenkov · 2017-07-06T20:46:42Z

#42899 looks like a likely reason
cc @alexcrichton @japaric

Affected run-pass tests (there are also failing tests in other groups):

    [run-pass] run-pass\debuginfo-lto.rs
    [run-pass] run-pass\panic-runtime\lto-abort.rs
    [run-pass] run-pass\panic-runtime\lto-unwind.rs
    [run-pass] run-pass\sepcomp-lib-lto.rs

Failures look like this:

---- [run-pass] run-pass\sepcomp-lib-lto.rs stdout ----

error: compilation failed!
status: exit code: 101
command: PATH="blahblahblah" C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\bin\rustc.exe C:/msys64/home/we/rust\src/test\run-pass\sepcomp-lib-lto.rs -L C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\test\run-pass --target=x86_64-pc-windows-gnu -L C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\test\run-pass\sepcomp-lib-lto.stage2-x86_64-pc-windows-gnu.run-pass.libaux -o C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\test\run-pass\sepcomp-lib-lto.stage2-x86_64-pc-windows-gnu.exe -Crpath -O -Lnative=C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\native\rust-test-helpers -C lto -g
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
error: linking with `gcc` failed: exit code: 1
  |
  = note: "gcc" "-Wl,--enable-long-section-names" "-fno-use-linker-plugin" "-Wl,--nxcompat" "-nostdlib" "-m64" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib\\crt2.o" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib\\rsbegin.o" "-L" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\test\\run-pass\\sepcomp-lib-lto.0.o" "-o" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\test\\run-pass\\sepcomp-lib-lto.stage2-x86_64-pc-windows-gnu.exe" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\test\\run-pass" "-L" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\test\\run-pass\\sepcomp-lib-lto.stage2-x86_64-pc-windows-gnu.run-pass.libaux" "-L" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "-L" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib" "-Wl,-Bstatic" "C:\\Users\\we\\AppData\\Local\\Temp\\rustc.awTF0ygPNTLw\\libstd-0159a69b5420bf5d.rlib" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib\\libcompiler_builtins-9fc12bc5201b06f7.rlib" "-Wl,-Bdynamic" "-l" "advapi32" "-l" "ws2_32" "-l" "userenv" "-l" "shell32" "-Wl,-Bstatic" "-l" "gcc_eh" "-l" "pthread" "-Wl,-Bdynamic" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-luser32" "-lkernel32" "C:\\msys64\\home\\we\\rust\\build\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib\\rsend.o"
  = note: C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0xd3): undefined reference to `rust_eh_unwind_resume'
          C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0x105): undefined reference to `rust_eh_unwind_resume'
          C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0x200): undefined reference to `rust_eh_unwind_resume'
          C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0x242): undefined reference to `rust_eh_unwind_resume'
          C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0x339): undefined reference to `rust_eh_unwind_resume'
          C:\msys64\home\we\rust\build\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib\libcompiler_builtins-9fc12bc5201b06f7.rlib(compiler_builtins-9fc12bc5201b06f7.0.o):(.text+0x37e): more undefined references to `rust_eh_unwind_resume' follow
          collect2.exe: error: ld returned 1 exit status


error: aborting due to previous error


------------------------------------------

thread '[run-pass] run-pass\sepcomp-lib-lto.rs' panicked at 'explicit panic', C:\msys64\home\we\rust\src\tools\compiletest\src\runtest.rs:2473:8

This happens on Windows/GNU (which seems to be the only target using rust_eh_unwind_resume).

The text was updated successfully, but these errors were encountered:

alexcrichton · 2017-07-10T17:27:39Z

One cause of this is #43150 as we shouldn't codegen these function calls anyway, still investigating.

alexcrichton · 2017-07-10T17:40:49Z

Ok looks like this is also due to #43151.

I think to paper over this issue we should just unconditionally compile compiler-builtins with panic=abort. This in theory is as easy as adding a clause here to also check for compiler_builtins, but I believe this will thwart the compiler's internal check that all crates are compiled with the same panic mode, so it's unlikely to be this trivial.

I'm going to tag this as a regression as I think this won't affect just the bootstrap, but any builds with LTO that end up not using symbols from core.

alexcrichton · 2017-07-10T19:19:30Z

I've also filed rust-lang/compiler-builtins#177 to track the fix there. That includes a test which fails today and when passing should solve this issue.

brson · 2017-07-13T16:48:18Z

Compiler team might want to be aware of this. It seems to just impact our own bootstrap though. P-?

@alexcrichton

Compile `compiler_builtins` with `abort` panic strategy A workaround for #43095 In case this causes unexpected consequences, I use a simpler workaround locally: ```diff --- a/src/bootstrap/bin/rustc.rs +++ b/src/bootstrap/bin/rustc.rs @@ -175,7 +175,9 @@ fn main() { } if let Ok(s) = env::var("RUSTC_CODEGEN_UNITS") { - cmd.arg("-C").arg(format!("codegen-units={}", s)); + if crate_name != "compiler_builtins" { + cmd.arg("-C").arg(format!("codegen-units={}", s)); + } } // Emit save-analysis info. ``` r? @alexcrichton

@alexcrichton

Compile `compiler_builtins` with `abort` panic strategy A workaround for #43095 In case this causes unexpected consequences, I use a simpler workaround locally: ```diff --- a/src/bootstrap/bin/rustc.rs +++ b/src/bootstrap/bin/rustc.rs @@ -175,7 +175,9 @@ fn main() { } if let Ok(s) = env::var("RUSTC_CODEGEN_UNITS") { - cmd.arg("-C").arg(format!("codegen-units={}", s)); + if crate_name != "compiler_builtins" { + cmd.arg("-C").arg(format!("codegen-units={}", s)); + } } // Emit save-analysis info. ``` r? @alexcrichton

petrochenkov · 2017-07-19T09:52:06Z

I'll close this since the immediate problem is fixed and the underlying issues have their own issues.

CryZe mentioned this issue Jul 7, 2017

wasm32-unknown-emscripten programs crash with codegen-units > 1 #43101

Closed

alexcrichton added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jul 10, 2017

alexcrichton mentioned this issue Jul 10, 2017

Undefined references to rust_eh_unwind_resume on x86_64-pc-windows-gnu rust-lang/compiler-builtins#177

Closed

brson added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-nominated labels Jul 13, 2017

petrochenkov mentioned this issue Jul 15, 2017

Compile compiler_builtins with abort panic strategy #43258

Merged

petrochenkov closed this as completed Jul 19, 2017

tshepang mentioned this issue Oct 31, 2022

Don't build compiler_builtins with -C panic=abort #103786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A number of tests fails with undefined references to `rust_eh_unwind_resume` when codegen-units > 1 #43095

A number of tests fails with undefined references to `rust_eh_unwind_resume` when codegen-units > 1 #43095

petrochenkov commented Jul 6, 2017 •

edited by sanxiyn

Loading

alexcrichton commented Jul 10, 2017

alexcrichton commented Jul 10, 2017

alexcrichton commented Jul 10, 2017

brson commented Jul 13, 2017 •

edited

Loading

petrochenkov commented Jul 19, 2017

A number of tests fails with undefined references to rust_eh_unwind_resume when codegen-units > 1 #43095

A number of tests fails with undefined references to rust_eh_unwind_resume when codegen-units > 1 #43095

Comments

petrochenkov commented Jul 6, 2017 • edited by sanxiyn Loading

alexcrichton commented Jul 10, 2017

alexcrichton commented Jul 10, 2017

alexcrichton commented Jul 10, 2017

brson commented Jul 13, 2017 • edited Loading

petrochenkov commented Jul 19, 2017

A number of tests fails with undefined references to `rust_eh_unwind_resume` when codegen-units > 1 #43095

A number of tests fails with undefined references to `rust_eh_unwind_resume` when codegen-units > 1 #43095

petrochenkov commented Jul 6, 2017 •

edited by sanxiyn

Loading

brson commented Jul 13, 2017 •

edited

Loading