Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression on nightly-2017-11-20 #46364

Closed
niklasf opened this issue Nov 29, 2017 · 2 comments
Closed

Performance regression on nightly-2017-11-20 #46364

niklasf opened this issue Nov 29, 2017 · 2 comments
Labels
C-bug Category: This is a bug. I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@niklasf
Copy link
Contributor

niklasf commented Nov 29, 2017

Source code under test: https://github.com/niklasf/shakmaty

Before:

$ cargo +nightly-2017-11-20 bench
[...]
test perft::tests::bench_deep_perft               ... bench:  29,666,456 ns/iter (+/- 10,492,824)
test perft::tests::bench_shallow_perft            ... bench:   1,153,713 ns/iter (+/- 3,677)
test position::tests::bench_generate_moves        ... bench:         122 ns/iter (+/- 3)
test position::tests::bench_play_unchecked        ... bench:          10 ns/iter (+/- 0)
test position::tests::bench_san_candidates        ... bench:          15 ns/iter (+/- 0)
test san::tests::bench_parse_san_move_complicated ... bench:          10 ns/iter (+/- 0)

After:

$ cargo +nightly-2017-11-21 bench
[...]
test perft::tests::bench_deep_perft               ... bench:  34,374,405 ns/iter (+/- 2,849,721)
test perft::tests::bench_shallow_perft            ... bench:   1,317,448 ns/iter (+/- 1,264)
test position::tests::bench_generate_moves        ... bench:         159 ns/iter (+/- 2)
test position::tests::bench_play_unchecked        ... bench:          14 ns/iter (+/- 0)
test position::tests::bench_san_candidates        ... bench:          15 ns/iter (+/- 0)
test san::tests::bench_parse_san_move_complicated ... bench:           9 ns/iter (+/- 0)

Platform:

binary: rustc
host: x86_64-unknown-linux-gnu
LLVM version: 4.0

I suspect it's related to #45225. Advice on how to debug this or what further information would be useful is welcome.

@Mark-Simulacrum
Copy link
Member

Cc @eddyb

@kennytm kennytm added C-bug Category: This is a bug. I-slow Issue: Problems and improvements with respect to performance of generated code. labels Nov 29, 2017
@niklasf
Copy link
Contributor Author

niklasf commented May 25, 2018

With some optimizations it's almost back to the original level of performance. I did not find anything specific that should be improved in rustc.

@niklasf niklasf closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Development

No branches or pull requests

3 participants