Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc doesn't link correctly to methods in trait implementations #49455

Closed
frewsxcv opened this issue Mar 28, 2018 · 3 comments
Closed

rustdoc doesn't link correctly to methods in trait implementations #49455

frewsxcv opened this issue Mar 28, 2018 · 3 comments
Assignees
@GuillaumeGomez
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Mar 28, 2018 •
edited
Loading

https://doc.rust-lang.org/nightly/std/?search=until

screen shot 2018-03-28 at 3 14 37 pm
@frewsxcv
Copy link
Member Author

I learned via @QuietMisdreavus on IRC that they do have these methods via generic trait implementations, but the hyperlinks to the method definitions in the impls are broken.

@frewsxcv frewsxcv changed the title rustdoc lists results for methods which don't exist rustdoc doesn't link correctly to methods in trait implementations Mar 28, 2018
@QuietMisdreavus
Copy link
Member

The link anchors exist in the HTML, but they don't exist by default because the anchor is hidden by the automatic folding of trait implementations.

@GuillaumeGomez Should the search index links for trait implementations link to the trait impl itself now? Otherwise the link anchor goes nowhere and the user doesn't see where the method comes from.

@GuillaumeGomez
Copy link
Member

I'll need to think about it.

@GuillaumeGomez GuillaumeGomez self-assigned this Mar 28, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 4, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Apr 6, 2018
@kennytm
Rollup merge of rust-lang#49652 - GuillaumeGomez:anchor-collapsed, r=…
5751c66 
…QuietMisdreavus

Fix anchors issue when everything is collapsed

Fixes rust-lang#49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this issue Apr 7, 2018
@kennytm
Rollup merge of rust-lang#49652 - GuillaumeGomez:anchor-collapsed, r=…
91e81fa 
…QuietMisdreavus

Fix anchors issue when everything is collapsed

Fixes rust-lang#49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus
@QuietMisdreavus QuietMisdreavus added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @GuillaumeGomez @QuietMisdreavus