Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide config.toml flag (or so) to compile without deny(warnings) #49517

Closed
RalfJung opened this issue Mar 30, 2018 · 2 comments
Closed

Provide config.toml flag (or so) to compile without deny(warnings) #49517

RalfJung opened this issue Mar 30, 2018 · 2 comments
Assignees
@Mark-Simulacrum
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 30, 2018 •
edited by eddyb

It would sometimes be nice to run the compiler on a testcase even though there are currently warnings in the compiler. One way might be to have a config.toml flag that controls this.

Cc @eddyb
@eddyb eddyb changed the title Provide configure.toml flag (or so) to compile without deny(warnings) Provide config.toml flag (or so) to compile without deny(warnings) Mar 30, 2018
@eddyb
Copy link
Member

eddyb commented Mar 30, 2018

cc @alexcrichton @Mark-Simulacrum

Maybe we can move the #![deny(warnings)] out of all the crates, and into rustbuild?

@Mark-Simulacrum Mark-Simulacrum added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 30, 2018
@Mark-Simulacrum Mark-Simulacrum self-assigned this Apr 1, 2018
@Mark-Simulacrum
Copy link
Member

I have a branch that fixes this based on the rustbuild-test branch to avoid rebasing. Will make a PR once the testing work lands.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Apr 5, 2018
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Apr 8, 2018
@Mark-Simulacrum
Move deny(warnings) into rustbuild
c115cc6 
This permits easier iteration without having to worry about warnings
being denied.

Fixes rust-lang#49517
bors added a commit that referenced this issue Apr 11, 2018
@bors
Auto merge of #49715 - Mark-Simulacrum:deny-warnings, r=alexcrichton
43e994c 
Move deny(warnings) into rustbuild

This permits easier iteration without having to worry about warnings
being denied.

Fixes #49517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddyb @RalfJung @Mark-Simulacrum