-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tarball for rustc 1.27.0 is not able to rebuildable itself #51650
Comments
There isn't much we can do without a new error-chain release. #51501 Beyond switching |
Why hasn't this been caught while 1.27.0 was in beta? |
@est31 it is failing in a specific configuration: rebuilding. bots are testing rustc-1.26.2 is able to build rustc-1.27.0, but not rustc-1.27.0 to be able to build rustc-1.27.0 |
@semarie yeah but it should show up when 1.27.0 tries to build whatever is on nightly. |
@est31 here my analysis. currently nightly is build using 03fb2f4 . I downloaded a beta tarball pointed by https://github.com/rust-lang/rust/blob/master/src/stage0.txt#L15 and checked the The rename so if I didn't mess myself, it seems to me that the latest commit in the beta branch isn't used to build nightly. so not all changes are tested in beta. |
Oh that's unfortunate. Thanks @semarie for digging this up. Right so I see the following options:
|
This is indeed unfortunate (sorry about the problem here!) -- I think you should be able to fix this by changing config.toml to have deny-warnings set to false in the |
Passing |
[beta] Prepare 1.28.0 beta release This feels likely to fail due to #51650 but I want to see what CI says.
What needs to be done for this issue to be resolved? |
I think the recommended fix for this issue is #51650 (comment): it's not hard for downstream users to follow it, and it's too late for us to rebuild the tarballs of 1.27.0. |
while preparing packaging of upcoming rustc 1.27.0 (stable) for OpenBSD, I found it is not able to fully rebuild itself.
exactly, rustc-1.27.0 fails to build
rust-installer
tool, due toerror-chain
crate, due tounused_doc_comment has been renamed to unused_doc_comments
lint error.strictly speaking, rustc 1.27.0 is able to bootstrap itself. but the distributed tarball doesn't permit such bootstrapping. it is a niche problem that could affect downstream while packaging.
note:
git-commit-hash
pointing to e0d93fcerror-chain
crate packaged has information package (in.cargo-checksum.json
) ff511d5dc435d703f4971bc399647c9bc38e20cb41452e3b9feb4765419ed3f3The text was updated successfully, but these errors were encountered: