pretty/record-trailing-comma is xfailed #5181
Labels
A-pretty
Area: Pretty printing.
A-testsuite
Area: The testsuite used to check the correctness of rustc
Comments
ghost
assigned 
|
Still broken. |
|
linking to the metabug #3195 so that this ticket gets an entry (with status) in its comments area. |
|
Clearing milestone |
|
triage: test is still failing |
|
What is the full path to this test? |
|
It seems that this test was removed in bba934f, so this can be closed. |
|
Thanks @apasel422 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
…flip1995 Expand `missing_errors_doc` to also work on async functions This adds the `missing_errors_doc` lint to async functions. changelog: Make [`missing_errors_doc`] lint also trigger on `async` functions
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
…shearth,llogiq,flip1995 I like to move it, move it GHA now runs in the background for 6 days (rust-lang#5088) Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle)) Some PRs were: - rust-lang#5163 - rust-lang#5170 - rust-lang#5168 - rust-lang#5173 - rust-lang#5171 - rust-lang#5156 - rust-lang#4809 - rust-lang#5177 - rust-lang#5182 - rust-lang#5183 - rust-lang#5184 - rust-lang#5185 - rust-lang#5186 - rust-lang#5181 - rust-lang#5189 Bug with GHA: - When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in rust-lang#5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes - Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet) ## Before merging this, rust-lang/rust-central-station#578 has to get merged This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move. changelog: Clippy completely runs on GHA now 🎉 --- BTW: The deployment already runs on GHA, instead of Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I thought I fixed this bug before, but I'll look into it later; I wanted to get the other post-snapshot changes in.
The text was updated successfully, but these errors were encountered: