Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uppretty print source comparison failures are not fatal #52255
Comments
Centril
added
C-bug
T-infra
labels
Jul 11, 2018
bors
added a commit
that referenced
this issue
Jul 12, 2018
bors
added a commit
that referenced
this issue
Jul 12, 2018
bors
closed this
in
f0b1a78
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tinco commentedJul 11, 2018
Since 7948afd the
compare_sourcecheck no longer panics on failure. It is obvious in the commit that thepanicinvocation is removed from the check, and no other changes are made in the function to remedy it.It can be verified by adding a new pretty test case like:
The resulting pretty printed file is slightly different, the comparison fails and the message is logged, but the test continues into the type check, which fails for a different reason and then panics. If you fix the type check (by adding the module and fn main) then the whole test passes and the error message is swallowed even though the source comparison is still not matching.