Paths in save-analysis files are not remapped by --remap-path-prefix #52549

jsgf · 2018-07-19T20:09:11Z

--remap-path-prefix is supposed to remap all references to paths in all output (error messages, debug info, etc). It looks like this isn't happening for save-analysis files.

For example, in current nightly: rustc 1.29.0-nightly (12ed235 2018-07-18)

This input

pub struct Foo;

rustc -Zsave-analysis -g --crate-type=rlib --emit=metadata t.rs --error-format json --remap-path-prefix=$(pwd)=.

produces a save-analysis file which still has references to my home dir:

        "external_crates": [
            {
                "file_name": "/Users/jsgf/t.rs",
                "id": {
                    "disambiguator": [
                        287500826263317014,
                        5864436369277545838
                    ],
                    "name": "std"
                },
                "num": 1
            },

Example in full output.

This is undesirable because it makes the output depend on the build directory, which breaks build artifact caching.

The text was updated successfully, but these errors were encountered:

jsgf · 2018-07-19T20:09:32Z

cc @nrc @Xanewok

@nrc

…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc

@nrc

…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc

@nrc

…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc

@nrc

…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc

@nrc

…=nrc Account for --remap-path-prefix in save-analysis Fixes rust-lang#52549. Didn't add a test since save-analysis is still unstable, only tested this locally. Should I add a test for that? If so, is run-make-fulldeps an appropriate format? Session is already created with remapped working directory, so use that instead of the actual cwd. This was the only place affected, since the rest of the paths in save-analysis are directly derived from files in spans from `sess.codemap()`, which already creates remapped ones. r? @nrc

kennytm added A-save-analysis Area: saving results of analyses such as inference and borrowck results to a file. C-bug Category: This is a bug. labels Jul 19, 2018

nrc added the T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. label Jul 19, 2018

Xanewok mentioned this issue Aug 6, 2018

Account for --remap-path-prefix in save-analysis #53110

Merged

bors closed this as completed in #53110 Aug 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Paths in save-analysis files are not remapped by --remap-path-prefix #52549

Paths in save-analysis files are not remapped by --remap-path-prefix #52549

jsgf commented Jul 19, 2018 •

edited

Loading

jsgf commented Jul 19, 2018

Paths in save-analysis files are not remapped by --remap-path-prefix #52549

Paths in save-analysis files are not remapped by --remap-path-prefix #52549

Comments

jsgf commented Jul 19, 2018 • edited Loading

jsgf commented Jul 19, 2018

jsgf commented Jul 19, 2018 •

edited

Loading