x.py test now requires Sparc target to be enabled in LLVM
#52881
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
O-SPARC
Target: SPARC processors
Comments
petrochenkov
added
the
A-testsuite
|
The test should be marked |
|
Hmm, |
nagisa
added a commit
to nagisa/rust
that referenced
this issue
Jul 31, 2018
It is not required for LLVM to have SPARC target support, so it is necessary to only run this test when LLVM does support SPARC. Sadly, it isn’t possible to specify exactly this constraint. Instead, we specify that this test should run on SPARC host only (it surely is sane assumption to make that compiler running on a SPARC can generate SPARC, right?) Since you cannot specify multiple `only-*` to have it run on both 32-bit and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is being tested by this test. Fixes rust-lang#52881
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jul 31, 2018
…s, r=alexcrichton Only run the sparc-abi test on sparc It is not required for LLVM to have SPARC target support, so it is necessary to only run this test when LLVM does support SPARC. Sadly, it isn’t possible to specify exactly this constraint. Instead, we specify that this test should run on SPARC host only (it surely is sane assumption to make that compiler running on a SPARC can generate SPARC, right?) Since you cannot specify multiple `only-*` to have it run on both 32-bit and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is being tested by this test. Fixes rust-lang#52881
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this issue
Aug 1, 2018
…s, r=alexcrichton Only run the sparc-abi test on sparc It is not required for LLVM to have SPARC target support, so it is necessary to only run this test when LLVM does support SPARC. Sadly, it isn’t possible to specify exactly this constraint. Instead, we specify that this test should run on SPARC host only (it surely is sane assumption to make that compiler running on a SPARC can generate SPARC, right?) Since you cannot specify multiple `only-*` to have it run on both 32-bit and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is being tested by this test. Fixes rust-lang#52881
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this issue
Aug 1, 2018
…s, r=alexcrichton Only run the sparc-abi test on sparc It is not required for LLVM to have SPARC target support, so it is necessary to only run this test when LLVM does support SPARC. Sadly, it isn’t possible to specify exactly this constraint. Instead, we specify that this test should run on SPARC host only (it surely is sane assumption to make that compiler running on a SPARC can generate SPARC, right?) Since you cannot specify multiple `only-*` to have it run on both 32-bit and 64-bit SPARC we pick 64-bit SPARC, because it is exactly what is being tested by this test. Fixes rust-lang#52881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reducing the number of built LLVM targets reduces time to build LLVM.
Previously
targets = "X86;ARM"was enough to pass the testing successfully on a typical x86 machine, but recently one test (https://github.com/rust-lang/rust/blob/master/src/test/codegen/sparc-struct-abi.rs, cc @nagisa ) was added that requires enabling Sparc as well.Target specific tests like this should preferably be somehow ignored if necessary LLVM targets are not built, or simply not included into the test suite.
The text was updated successfully, but these errors were encountered: