Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in the test suite when removing a drop block from core::pipes #5377

Closed
bstrie opened this issue Mar 14, 2013 · 2 comments
Closed

Failure in the test suite when removing a drop block from core::pipes #5377

bstrie opened this issue Mar 14, 2013 · 2 comments
Assignees
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Milestone

Comments

@bstrie
Copy link
Contributor

bstrie commented Mar 14, 2013

The DropState struct in core::pipes still contains a drop block. Converting it to a trait causes an error while running the test suite:

error: test run failed!
command: x86_64-unknown-linux-gnu/test/run-pass/issue-3168.stage2-x86_64-unknown-linux-gnu
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
rust: ~"\"sibling fails\""
rust: task failed at 'explicit failure', /media/linhaus/rust/src/test/run-pass/issue-3168.rs:20
rust: ~"\"child blocks\""
rust: task failed at 'killed', /media/linhaus/rust/src/libcore/pipes.rs:322
rust: ~"\"parent tries\""
rust: task failed at 'assertion failed: !p.recv().try_send(())', /media/linhaus/rust/src/test/run-pass/issue-3168.rs:29
rust: domain main @0xbac9c0 root task failed

------------------------------------------

rust: task failed at 'explicit failure', /media/linhaus/rust/src/compiletest/runtest.rs:697
@graydon
Copy link
Contributor

graydon commented Apr 30, 2013

assigning bug; change assignment if you disagree

@ghost ghost assigned pcwalton Apr 30, 2013
@alexcrichton
Copy link
Member

This was dealt with in 7c9d089

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Development

No branches or pull requests

4 participants