Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless hang during stage1 when removing drop block from core::task::mod #5379

Closed
bstrie opened this issue Mar 14, 2013 · 4 comments
Closed

Endless hang during stage1 when removing drop block from core::task::mod #5379

bstrie opened this issue Mar 14, 2013 · 4 comments
Assignees
@pcwalton
Milestone
0.7

Comments

@bstrie
Copy link
Contributor

bstrie commented Mar 14, 2013

The AllowFailure struct in core::task::mod. Hangs infinitely while compiling stage1 libcore, with 0% CPU utilization from rustc.
@bstrie bstrie mentioned this issue Mar 15, 2013
Closed
@brson
Copy link
Contributor

brson commented Apr 29, 2013

I can still reproduce this, but will probably work around it by using finally, which is a better pattern here than creating new types anyway.

@brson
Copy link
Contributor

brson commented Apr 29, 2013

After that there is just one more use of drop in pipes.

brson added a commit to brson/rust that referenced this issue Apr 29, 2013
@brson
core: Replace uses of 'drop' in task module with 'finally'. rust-lang…
c1fdace 
…#5379
@graydon
Copy link
Contributor

graydon commented Apr 30, 2013

assigning bug; change assignment if you disagree

@ghost ghost assigned pcwalton Apr 30, 2013
@alexcrichton
Copy link
Member

This looks like it was fixed in c1fdace

oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5423 - rkuhn:add_futures_not_send, r=flip1995
f1fb815 
add lint futures_not_send

changelog: add lint futures_not_send

fixes rust-lang#5379

~Remark: one thing that can (should?) still be improved is to directly include the error message from the `Send` check so that the programmer stays in the flow. Currently, getting the actual error message requires a restructuring of the code to make the `Send` constraint explicit.~
It now shows all unmet constraints for allowing the Future to be Send.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
5 participants
@graydon @alexcrichton @brson @pcwalton @bstrie