Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse snapshot LLVM by default instead of rebuilding #5402

Closed
brson opened this issue Mar 15, 2013 · 8 comments
Closed

Reuse snapshot LLVM by default instead of rebuilding #5402

brson opened this issue Mar 15, 2013 · 8 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

Comments

@brson
Copy link
Contributor

brson commented Mar 15, 2013

For the most common use cases, it is not strictly necessary to rebuild LLVM. This will be very helpful for new users as well as for the servo bots.

@catamorphism
Copy link
Contributor

Nominating for milestone 5, production-ready

@graydon
Copy link
Contributor

graydon commented May 23, 2013

probably LLVM will be on its own package,

@graydon
Copy link
Contributor

graydon commented May 23, 2013

accepted for production-ready milestone

@pnkfelix
Copy link
Member

visited for bug triage from 2013-07-22.

Is this bug talking about hosting snapshots of the patched LLVM builds alongside our snapshots of rustc? Or is it talking about getting the snapshot from somewhere else after we have pushed our LLVM patches upstream?

(I am assuming the former, since I suspect we'd be okay with hosting LLVM snapshots and do not want to give up the flexibility of patching LLVM when necessary.)

@huonw
Copy link
Member

huonw commented Sep 23, 2013

Triage: still an issue.

@sanxiyn
Copy link
Member

sanxiyn commented Jan 23, 2014

Since #10809, snapshot is statically linked and there is no "snapshot LLVM" per se. What is the plan on this now?

@brson
Copy link
Contributor Author

brson commented Jan 23, 2014

I think this is probably irrelevant. Building LLVM is pretty fast lately since we stopped building so many components and with #9876 we'll provide binary nightly installers for users.

@pnkfelix
Copy link
Member

The main client who would benefit from this are new users, who would be better served by #9876.

So, closing in favor of #9876.

oli-obk pushed a commit to oli-obk/rust that referenced this issue Apr 2, 2020
…=flip1995

Allow let_underscore_must_use to be ignored

changelog: none
Fixes rust-lang#5366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
Projects
None yet
Development

No branches or pull requests

6 participants