Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap compiler on beta needs an update #55404

Closed
alexcrichton opened this issue Oct 27, 2018 · 1 comment
Closed

Bootstrap compiler on beta needs an update #55404

alexcrichton opened this issue Oct 27, 2018 · 1 comment
Labels
P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Milestone

Comments

@alexcrichton
Copy link
Member

Naively updating the bootstrap compiler yields:

error[E0658]: mod statements in non-mod.rs files are unstable (see issue #44660)
 --> /home/alex/.cargo/registry/src/github.com-1ecc6299db9ec823/chalk-engine-0.8.0/src/context.rs:7:16              
  |                                                                                                                 
7 | pub(crate) mod prelude;                                                                                         
  |                ^^^^^^^                                                                                          
  |                                                                                                                 
  = help: add #![feature(non_modrs_mods)] to the crate attributes to enable                                         
  = help: on stable builds, rename this file to context/mod.rs                                                      

I believe this was due to the last minute destabilization of this feature for the 1.30.0 release.

@nikomatsakis could a point release of the chalk-engine crate be made which builds on stable?

@alexcrichton alexcrichton added this to the 1.31 milestone Oct 27, 2018
@Mark-Simulacrum Mark-Simulacrum added P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Oct 27, 2018
bors added a commit that referenced this issue Oct 29, 2018
[beta]: Prepare the 1.31.0 beta release

* Update to Cargo's branched 1.31.0 branch
* Update the channel to `beta`

Rolled up beta-accepted PRs:

* #55362: Remove `cargo new --edition` from release notes.
* #55325: Fix link to macros chapter
* #55358: Remove redundant clone (2)
* #55346: Shrink `Statement`.
* #55274: Handle bindings in substructure of patterns with type ascriptions
* #55297: Partial implementation of uniform paths 2.0 to land before beta
* #55192: Fix ordering of nested modules in non-mod.rs mods
* #55185: path suggestions in Rust 2018 should point out the change in semantics
* #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch

Note that **this does not update the bootstrap compiler** due to #55404
alexcrichton added a commit to alexcrichton/rust that referenced this issue Oct 31, 2018
This follows up rust-lang#55405 with an update to the bootstrap compiler now that
a new version of `chalk-engine` is published.

Closes rust-lang#55404
@alexcrichton
Copy link
Member Author

This happened in #55550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants