Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should survey uses of #[rustc_error] and see if they can be replaced with // compile-pass #55505

Closed
pnkfelix opened this issue Oct 30, 2018 · 1 comment
Closed

should survey uses of #[rustc_error] and see if they can be replaced with // compile-pass #55505

pnkfelix opened this issue Oct 30, 2018 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

Discussing some of the difficulties with #54528 with @nikomatsakis led them to remind me that we originally introduced #[rustc_error] because we didn't have a way to express // compile-pass to the test infrastructure.

But now we do

and it would make sense for us to try to migrate instances of #[rustc_error] to use // compile-pass when possible.

(I think the main case where it is not possible are instances of // revisions where at least one of the revisions compiles successfully and another does not.)
@pnkfelix pnkfelix added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2018
@pnkfelix
Copy link
Member Author

pnkfelix commented Oct 30, 2018 •
edited
Loading

i guess they should also use // skip-trans or whatever it is that skips running LLVM

update: // skip-codegen; cc #49321

@pnkfelix pnkfelix mentioned this issue Oct 31, 2018
Merged
bors added a commit that referenced this issue Nov 8, 2018
@bors
Auto merge of #55532 - pnkfelix:rustc_error-survey, r=nikomatsakis
653da4f 
#[rustc_error] survey

Fix #55505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pnkfelix