Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing copies causing segfaults #5562

Closed
alexcrichton opened this issue Mar 26, 2013 · 1 comment
Closed

Removing copies causing segfaults #5562

alexcrichton opened this issue Mar 26, 2013 · 1 comment

Comments

@alexcrichton
Copy link
Member

When transitioning from oldmap::HashMap to LinearMap in #5523, I ran into a number of spots which caused segfaults when compiling some time between stage1 and stage2.

Each segfault could be fixed with a copy, although the copy isn't necessary in most cases. This mostly showed up with types of the form &*T, and the copy ended up yielding a *T type.

I wasn't able to track it down much further, but there are a number of spots throughout the compiler marked with a FIXME for this issue.
@alexcrichton alexcrichton mentioned this issue Mar 26, 2013
Closed
@nikomatsakis
Copy link
Contributor

I am 99% sure I know the origin of this problem. As part of my fix for #5910, I encountered several of these copies at locations where hashtables were being mutated while being iterated. This was going undetected due to numerous bugs in the @mut write guard code. Therefore, I am going to close this bug as a dup of #5910.

nikomatsakis added a commit to nikomatsakis/rust that referenced this issue May 5, 2013
@nikomatsakis
Address all FIXMEs from rust-lang#5562
6cb273e
flip1995 pushed a commit to flip1995/rust that referenced this issue May 27, 2020
@bors
Auto merge of rust-lang#5562 - flip1995:clippyup_up, r=phansch
578692d 
Update contributing section about syncing Clippy

[Rendered](https://github.com/flip1995/rust-clippy/blob/clippyup_up/CONTRIBUTING.md#fixing-build-failures-caused-by-rust)

r? @oli-obk Did I get the sync process right?

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @nikomatsakis