Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upStabilize uniform paths on Rust 2018 (technical details) #56417
Comments
This comment has been minimized.
This comment has been minimized.
|
So, we need to either:
|
petrochenkov
added
A-resolve
T-lang
B-unstable
labels
Dec 1, 2018
This was referenced Dec 1, 2018
Centril
added
the
C-tracking-issue
label
Dec 2, 2018
Centril
self-assigned this
Dec 2, 2018
petrochenkov
self-assigned this
Dec 2, 2018
This comment has been minimized.
This comment has been minimized.
|
#56759 implements suggestions for macro_rules and attribute import future-proofing. |
petrochenkov
referenced this issue
Dec 14, 2018
Closed
Unhelpful error message for missing `crate` in uses import #56821
added a commit
that referenced
this issue
Jan 12, 2019
added a commit
that referenced
this issue
Jan 12, 2019
bors
closed this
in
#56759
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petrochenkov commentedDec 1, 2018
•
edited
#55618 is the high-level and high-volume thread on whether we want uniform import paths in the language in general or not.
This is a more focused issue about how exactly stabilization will happen (assuming it will happen in general).
First, regarding timing of the stabilization.
I propose to test uniform paths for 4-5 weeks starting from Dec 07 (Rust 2018 release, 1.31 stable), and then backport their stabilization on 1.32 beta if everything is good.
Second, regarding sub-features and partial stabilization.
Imports
use NAMEoruse NAME::...in the uniform path model can refer to various entities, not all of which may be expected or were discussed.Here's the list:
mod m { struct NAME; },fn f() { struct NAME; }).No known issues to resolve before stabilization.
#[macro_use] extern crate ..., for exampleuse panicfrom the standard library.No known issues to resolve before stabilization.
use stdoruse regex.No known issues to resolve before stabilization.
use Vec.No known issues to resolve before stabilization.
use u8.No known issues to resolve before stabilization.
use env.Currently an error due to some (fixable) implementation details of built-in macros.
No known issues to resolve before stabilization (after the error is removed).
macro_rules!in the same crate, e.g.macro_rules! mac {()=>()} use mac as pacUnresolved question: what visibility to attach to these macros, in other words - how far can they be reexported with
pub use?Proposal: treat
#[macro_export] macro_rules! { ... }aspub, treat othermacro_rules! { ... }aspub(crate).Motivation: 1)
#[macro_export]are indeed visible from other crates, 2) non-#[macro_export]macros themselves are indeed potentially visible from the whole crate, it depends on the containing module whether to actually let them out or not (similarly to public items in private modules and their potential reexports).use inline.Issue: even if
inlineis reimported under some other name, e.g.use inline as my_inline,my_inlinewon't be treated asinlineby the compiler. Even later stages of the compiler work with attributes at token level, not using resolution results. That's not good in general, ideally attributes should be lowered into some semantic form somewhere around AST -> HIR conversion.This means a compatibility hazard, for example
#[my_repr(D)] fn f() {}would be accepted and ignored if attributes are treated syntactically (assuminguse repr as my_repr), but would be an error if attributes are treated semantically based on their resolution.On the other hand, if
use builtin_attris still feature-gated, then things likeuse proc_macro(oruse ignoreas recently reported) will be feature gated as well (useimports in all namespaces, andproc_macrois not only a crate, but also a built-in attribute).Proposal: Allow imports of built-in attributes, but prohibit actually using names imported this way in attribute positions.
use serdeattribute registered bySerializemacro.Not fully implemented, so imports can never refer to them.
Issue (once fully implemented): similarly to built-in attributes, derive helpers reimported under other name will be unrecognizable by their respective proc macros, because proc macros work at token level.
Proposal: Allow imports of derive helper attributes, but prohibit actually using names imported this way in attribute positions.
rusfmtinrustfmt::skip.Issue: similarly to built-in attributes, tool modules reimported under other name will be unrecognizable by their respective tools, because tools work at token level.
Proposal: Allow imports of tool modules, but prohibit actually using names imported this way in attribute paths.