Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for Iterator::copied #57127

Closed
xfix opened this issue Dec 26, 2018 · 10 comments

Comments

Projects
None yet
7 participants
@xfix
Copy link
Contributor

commented Dec 26, 2018

This is a tracking issue for Iterator::copied.

Added in #56534. Feature gate: #![feature(iter_copied)].

Related feature: copied in #57126.

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

@Centril, do you feel your comment in #57126 (comment) is still an objection to the state of this feature, given the response in #57126 (comment)?

@Centril

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@SimonSapin So ultimately, #57970 was closed meaning that we are comfortable with the specialization. If that specialization is always in place then Copied is a redundant type (and the impls that come with it are also redundant). However, keeping the cost and the Copied type also has less of a risk attached to it so there's a trade-off here. I don't know what the right choice is, but those are the facts as I see them.

@xfix

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

@hellow554 Fixed :).

@xfix

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

@Manishearth

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@Centril Is there anything blocking stabilization here? We'd like to suggest this in Clippy, see rust-lang/rust-clippy#3958

(The crux is that .copied() is clearer than .map(|&x| x), but .cloned() gives off the wrong impression)

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@Manishearth That's not my call... =D

Picking random libs member... @sfackler is there anything blocking stabilization here?

@sfackler

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Doesn't seem like it.

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

commented Apr 17, 2019

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

commented Apr 17, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

commented Apr 27, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

bors added a commit that referenced this issue Apr 28, 2019

Auto merge of #60333 - Centril:stabilize-iterator-copied, r=varkor
Stabilize Iterator::copied in 1.36.0

Per #57127 (comment).

Closes #57127.

r? @varkor

@bors bors closed this in #60333 Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.