Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementors in documentation aren't clickable #57695

Closed
KamilaBorowska opened this issue Jan 17, 2019 · 8 comments
Closed

Implementors in documentation aren't clickable #57695

KamilaBorowska opened this issue Jan 17, 2019 · 8 comments
Assignees
Labels
C-bug Category: This is a bug. P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@KamilaBorowska
Copy link
Contributor

Compare:

https://doc.rust-lang.org/stable/std/panic/trait.RefUnwindSafe.html
https://doc.rust-lang.org/nightly/std/panic/trait.RefUnwindSafe.html

It's not possible to click on AtomicBool in impl RefUnwindSafe for AtomicBool anymore, while it is possible on stable and beta.

@hellow554
Copy link
Contributor

hellow554 commented Jan 17, 2019

cc @GuillaumeGomez

@Centril Centril added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jan 17, 2019
@hellow554
Copy link
Contributor

hellow554 commented Jan 17, 2019

This also applies to every "Implementations" item, e.g. for "Trait Implementations", "Auto Trait Implementations" and "Blanket Implementations", e.g. on https://doc.rust-lang.org/nightly/std/iter/struct.Map.html

@Centril Centril added P-high High priority C-bug Category: This is a bug. labels Jan 17, 2019
@Centril
Copy link
Contributor

Centril commented Jan 17, 2019

@Centril Centril added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Jan 17, 2019
@hellow554
Copy link
Contributor

Funny enough, the link is still there, but you can't click it

grafik

Not entirely sure, but it may be #56874 @JohnHeitmann

@hellow554
Copy link
Contributor

hellow554 commented Jan 17, 2019

It is the display: flex from the h3. If I remove that attribute with the developer console I can click the link. I'm not very familar with flex (although I heard it is super cool!), so I cannot say what exactly happens here. Maybe a browser bug?

@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2019

Looks like the z-index of the <code> tag is the problem:

Removing the

.in-band, code {
    z-index: -5;
}

makes the links work again.

@GuillaumeGomez
Copy link
Member

I'll take a look (and thanks @m-ou-se for the lead!).

@JohnHeitmann
Copy link
Contributor

My change broke that. Sorry folks! @GuillaumeGomez's fix looks good to me.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 18, 2019
…etMisdreavus

Fix non-clickable urls

Fixes rust-lang#57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 18, 2019
…etMisdreavus

Fix non-clickable urls

Fixes rust-lang#57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. P-high High priority T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants