Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the longest-match logic in module-name matching for logging #6032

Closed
pcwalton opened this issue Apr 23, 2013 · 6 comments
Closed

Remove the longest-match logic in module-name matching for logging #6032

pcwalton opened this issue Apr 23, 2013 · 6 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@pcwalton
Copy link
Contributor

It's rather confusing.

@bblum
Copy link
Contributor

bblum commented Jun 11, 2013

nominating for feature-complete milestone

@huonw
Copy link
Member

huonw commented Aug 5, 2013

Triage 2013-08-05: I believe this is still around; a minor part of #3309.

@graydon
Copy link
Contributor

graydon commented Aug 22, 2013

just a bug, removing milestone/nomination.

@alexcrichton
Copy link
Member

I would want to nominate this, but it appears that it was previously deemed as just a bug. To me it's not clear that this should be removed right-out but perhaps replaced with something, and if it's replaced with something with what?

I find it kinda convenient to have prefix matching, but then again I also haven't attempted to get the logs of rustc::middle::ty only get inundated with rustc::middle:typeck

@alexcrichton
Copy link
Member

cc @nick29581, could this move to https://github.com/rust-lang/log?

@rust-highfive
Copy link
Collaborator

This issue has been moved to the RFCs repo: rust-lang/log#6

flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 24, 2020
into_iter_on_ref: rephrase lint message: will not move the x -> will not consume the x

imo that's a bit clearer.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Development

No branches or pull requests

6 participants