Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move async/await UI tests into a folder #60418

Closed
cramertj opened this issue Apr 30, 2019 · 2 comments
Closed

Move async/await UI tests into a folder #60418

cramertj opened this issue Apr 30, 2019 · 2 comments
Assignees
@cramertj
Labels
A-async-await Area: Async & Await A-testsuite Area: The testsuite used to check the correctness of rustc AsyncAwait-Polish Async-await issues that are part of the "polish" area C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@cramertj
Copy link
Member

cramertj commented Apr 30, 2019 •
edited by Centril

We want to move all async / await tests (run-pass, ui, ...) into a single folder under src/test/ui/async-await to facilitate overview and the eventual stabilization report. Organization beyond that into sub-folders would also be useful to further make everything clear and reviewable.
@cramertj cramertj added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Apr 30, 2019
@cramertj cramertj self-assigned this Apr 30, 2019
@cramertj cramertj mentioned this issue Apr 30, 2019
Merged
@Centril Centril added A-async-await Area: Async & Await AsyncAwait-Unclear A-testsuite Area: The testsuite used to check the correctness of rustc AsyncAwait-Polish Async-await issues that are part of the "polish" area and removed AsyncAwait-Unclear labels Apr 30, 2019
@Centril
Copy link
Contributor

Centril commented May 4, 2019

Labeling as "blocking" since this should be done as part of the run up to the report.

@varkor
Copy link
Member

varkor commented May 25, 2019

Fixed in #61138.

@varkor varkor closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramertj cramertj

Labels
A-async-await Area: Async & Await A-testsuite Area: The testsuite used to check the correctness of rustc AsyncAwait-Polish Async-await issues that are part of the "polish" area C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Centril @varkor @cramertj