Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move async/await tests to their own folder #61138

Merged
merged 8 commits into from May 25, 2019

Conversation

Projects
None yet
4 participants
@varkor
Copy link
Member

commented May 24, 2019

This moves run-pass and ui async/await tests to their own folder src/test/ui/async-await and organises some into subfolders. (It does not move rustdoc tests for async/await.)

I also did some drive-by cleaning up of issues/error code tests into their own folders (which already existed). These are in separate commits, so easy to separate out if that's more desirable.

r? @cramertj

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented May 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1e8d3ef2:start=1558732239545150917,finish=1558732240309206454,duration=764055537
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
    99% |████████████████████████████████| 542kB 41.7MB/s eta 0:00:01
    100% |████████████████████████████████| 552kB 19.2MB/s 
Requirement already satisfied: PyYAML<=3.13,>=3.10 in /usr/lib/python2.7/dist-packages (from awscli) (3.11)
Collecting botocore==1.12.156 (from awscli)
  Downloading https://files.pythonhosted.org/packages/f5/aa/79fc47ccc3c7d0f36aafb9d85091d7d8a8f10d8ad24ccf3a89cf126b9f4e/botocore-1.12.156-py2.py3-none-any.whl (5.4MB)
    0% |▏                               | 20kB 28.9MB/s eta 0:00:01
    0% |▏                               | 30kB 33.5MB/s eta 0:00:01
    0% |▎                               | 40kB 34.8MB/s eta 0:00:01
    0% |▎                               | 51kB 35.5MB/s eta 0:00:01
---
tidy check
[00:04:25] * 574 error codes
[00:04:25] * highest error code: E0729
[00:04:27] * 255 features
[00:04:30] Stray file with UI testing output: "/checkout/src/test/ui/no-args-non-move-async-closure.stderr"
[00:04:30] some tidy checks failed
[00:04:30] 
[00:04:30] 
[00:04:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:30] 
[00:04:30] 
[00:04:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:30] Build completed unsuccessfully in 0:01:11
[00:04:30] Build completed unsuccessfully in 0:01:11
[00:04:30] Makefile:67: recipe for target 'tidy' failed
[00:04:30] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:13135845
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 21:15:21 UTC 2019
---
travis_time:end:110686cc:start=1558732522106005623,finish=1558732522110867268,duration=4861645
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:07a437f0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02a4f4eb
travis_time:start:02a4f4eb
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:08854cbf
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@cramertj

This comment has been minimized.

Copy link
Member

commented May 24, 2019

@bors r+

Thanks! :)

@bors

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

📌 Commit 79816bb has been approved by cramertj

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented May 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:001bba93:start=1558733872844623518,finish=1558733873645894496,duration=801270978
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:31] 
[01:08:31] running 5583 tests
[01:08:34] .................................................................................................... 100/5583
[01:08:34] ERROR 2019-05-24T22:46:38Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/async-await/auxiliary/arc_wake.rs` source not found"
[01:08:34] ERROR 2019-05-24T22:46:39Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/async-await/auxiliary/arc_wake.rs` source not found"
[01:08:39] .........F..........F............................................................................... 200/5583
[01:08:45] .................................................................................................... 400/5583
[01:08:49] ...................................................................................................i 500/5583
[01:08:52] .................................................................................................... 600/5583
[01:08:56] .................................................................................................... 700/5583
---
[01:12:00] failures:
[01:12:00] 
[01:12:00] ---- [ui] ui/async-await/async-await.rs stdout ----
[01:12:00] 
[01:12:00] error: aux-build `/checkout/src/test/ui/async-await/auxiliary/arc_wake.rs` source not found
[01:12:00] thread '[ui] ui/async-await/async-await.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2214:9
[01:12:00] 
[01:12:00] ---- [ui] ui/async-await/await-macro.rs stdout ----
[01:12:00] 
[01:12:00] 
[01:12:00] error: aux-build `/checkout/src/test/ui/async-await/auxiliary/arc_wake.rs` source not found
[01:12:00] thread '[ui] ui/async-await/await-macro.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2214:9
[01:12:00] 
[01:12:00] failures:
[01:12:00]     [ui] ui/async-await/async-await.rs
[01:12:00]     [ui] ui/async-await/await-macro.rs
[01:12:00]     [ui] ui/async-await/await-macro.rs
[01:12:00] 
[01:12:00] test result: FAILED. 5560 passed; 2 failed; 21 ignored; 0 measured; 0 filtered out
[01:12:00] 
[01:12:00] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:12:00] 
[01:12:00] 
[01:12:00] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:12:00] 
[01:12:00] 
[01:12:00] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:12:00] Build completed unsuccessfully in 0:04:45
[01:12:00] Build completed unsuccessfully in 0:04:45
[01:12:00] Makefile:48: recipe for target 'check' failed
[01:12:00] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0d89af0a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri May 24 22:50:05 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

The tests were passing locally, but that's because tests remain ignored even if their auxiliary files change, and I had moved some unintentionally.

@bors r=cramertj

@bors

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

📌 Commit c91ab64 has been approved by ``

@bors

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

📌 Commit c91ab64 has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61138 - varkor:async-await-tests, r=cramertj
Move async/await tests to their own folder

This moves run-pass and ui async/await tests to their own folder `src/test/ui/async-await` and organises some into subfolders. (It does not move rustdoc tests for async/await.)

I also did some drive-by cleaning up of issues/error code tests into their own folders (which already existed). These are in separate commits, so easy to separate out if that's more desirable.

r? @cramertj

Centril added a commit to Centril/rust that referenced this pull request May 25, 2019

Rollup merge of rust-lang#61150 - Centril:rollup-wmm7qga, r=Centril
Rollup of 13 pull requests

Successful merges:

 - rust-lang#61026 (Tweak macro parse errors when reaching EOF during macro call parse)
 - rust-lang#61095 (Update cargo)
 - rust-lang#61096 (tidy: don't short-circuit on license error)
 - rust-lang#61107 (Fix a couple docs typos)
 - rust-lang#61110 (Revert edition-guide toolstate override)
 - rust-lang#61111 (Fixed type-alias-bounds lint doc)
 - rust-lang#61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35)
 - rust-lang#61116 (Remove the incorrect warning from README.md)
 - rust-lang#61118 (Dont ICE on an attempt to use GAT without feature gate)
 - rust-lang#61121 (improve debug-printing of scalars)
 - rust-lang#61125 (Updated my mailmap entry)
 - rust-lang#61134 (Annotate each `reverse_bits` with `#[must_use]`)
 - rust-lang#61138 (Move async/await tests to their own folder)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 25, 2019

Auto merge of #61150 - Centril:rollup-wmm7qga, r=Centril
Rollup of 13 pull requests

Successful merges:

 - #61026 (Tweak macro parse errors when reaching EOF during macro call parse)
 - #61095 (Update cargo)
 - #61096 (tidy: don't short-circuit on license error)
 - #61107 (Fix a couple docs typos)
 - #61110 (Revert edition-guide toolstate override)
 - #61111 (Fixed type-alias-bounds lint doc)
 - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35)
 - #61116 (Remove the incorrect warning from README.md)
 - #61118 (Dont ICE on an attempt to use GAT without feature gate)
 - #61121 (improve debug-printing of scalars)
 - #61125 (Updated my mailmap entry)
 - #61134 (Annotate each `reverse_bits` with `#[must_use]`)
 - #61138 (Move async/await tests to their own folder)

Failed merges:

r? @ghost

@bors bors merged commit c91ab64 into rust-lang:master May 25, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@varkor varkor deleted the varkor:async-await-tests branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.