Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace POSIX glob implementation with an internal implementation #6100

Closed
doy opened this issue Apr 29, 2013 · 4 comments
Closed

replace POSIX glob implementation with an internal implementation #6100

doy opened this issue Apr 29, 2013 · 4 comments

Comments

@doy
Copy link
Contributor

doy commented Apr 29, 2013

This will be necessary for Windows support, as well as ensuring consistency across platforms and allowing more room for expansion of functionality. (In preparation for #5832.)
@yichoi
Copy link
Contributor

yichoi commented May 4, 2013

Android dose not support glob also

@yichoi yichoi mentioned this issue May 4, 2013
Merged
bors added a commit that referenced this issue May 5, 2013
@bors
auto merge of #6234 : yichoi/rust/glob-dummy-pull, r=thestinger
29a2a1e 
transitional patch to resolve compile/link failure on android

after #6161 landed, I've encountered below errors since android does not support glob in libc.

/opt/ndk_standalone/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: /home/yichoi/rust_work/build/x86_64-unknown-linux-gnu/stage1/lib/rustc/arm-linux-androideabi/lib/libcore-c3ca5d77d81b46c1-0.7-pre.so: error: undefined reference to 'glob'

/opt/ndk_standalone/bin/../lib/gcc/arm-linux-androideabi/4.6/../../../../arm-linux-androideabi/bin/ld: /home/yichoi/rust_work/build/x86_64-unknown-linux-gnu/stage1/lib/rustc/arm-linux-androideabi/lib/libcore-c3ca5d77d81b46c1-0.7-pre.so: error: undefined reference to 'globfre

Since android does not have `glob.h`, `glob_t` definition comes from
https://groups.google.com/forum/?fromgroups=#!topic/android-ndk/vSH6MWPD0Vk

#6100 should be resolved.
@emberian
Copy link
Member

emberian commented Jul 7, 2013

Still relevant

@Dretch
Copy link
Contributor

Dretch commented Jul 14, 2013

I am currently rewriting glob in rust.

Dretch added a commit to Dretch/rust that referenced this issue Aug 1, 2013
@Dretch
Replace os::glob with extra::glob, which is written in rust,
8a5a08e 
fixing issue rust-lang#6100.
@Dretch Dretch mentioned this issue Aug 1, 2013
Closed
Dretch added a commit to Dretch/rust that referenced this issue Sep 5, 2013
@Dretch
Replace os::glob with extra::glob, which is written in rust,
193a1c8 
fixing issue rust-lang#6100.
@emberian
Copy link
Member

emberian commented Nov 4, 2013

@Dretch did this, see extra::glob.

@emberian emberian closed this as completed Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@doy @emberian @Dretch @yichoi