Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sparcv9-sun-solaris and x86_64-sun-solaris missing rust-std #61174

Closed
gnzlbg opened this issue May 25, 2019 · 2 comments · Fixed by #61280
Closed

sparcv9-sun-solaris and x86_64-sun-solaris missing rust-std #61174

gnzlbg opened this issue May 25, 2019 · 2 comments · Fixed by #61280
Labels
O-solaris Operating system: Solaris T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented May 25, 2019 •
edited

Today's nightly (25-05-2019) is missing rust-std for:
@gnzlbg gnzlbg changed the title [regression] sparcv9-sun-solaris missing rust-std [regression] sparcv9-sun-solaris and x86_62-sun-solaris missing rust-std May 25, 2019
@jonas-schievink jonas-schievink added I-nominated O-solaris Operating system: Solaris regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 25, 2019
@gnzlbg gnzlbg changed the title [regression] sparcv9-sun-solaris and x86_62-sun-solaris missing rust-std [regression] sparcv9-sun-solaris and x86_64-sun-solaris missing rust-std May 25, 2019
@dhardy dhardy mentioned this issue May 28, 2019
Merged
@alexcrichton alexcrichton changed the title [regression] sparcv9-sun-solaris and x86_64-sun-solaris missing rust-std sparcv9-sun-solaris and x86_64-sun-solaris missing rust-std May 28, 2019
@alexcrichton alexcrichton removed I-nominated regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels May 28, 2019
@alexcrichton
Copy link
Member

This was pointed out in #61022 and looks to be fixed in #61055. It seems that #61055 flew in under the radar of #60777 where the actual change to disable these targets happened.

@bgermann want to send a PR to revert the changes in this file so the targets are built again?

@bgermann
Copy link
Contributor

Yes, I will do it today.

@bgermann bgermann mentioned this issue May 28, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue May 30, 2019
@Centril
Rollup merge of rust-lang#61280 - bgermann:master, r=alexcrichton
b726782 
Revert "Disable solaris target since toolchain no longer builds"

This reverts commit e764f47.
Fixes rust-lang#61174.
Centril added a commit to Centril/rust that referenced this issue May 30, 2019
@Centril
Rollup merge of rust-lang#61280 - bgermann:master, r=alexcrichton
8b55529 
Revert "Disable solaris target since toolchain no longer builds"

This reverts commit e764f47.
Fixes rust-lang#61174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-solaris Operating system: Solaris T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Disable solaris target since toolchain no longer builds"
4 participants
@alexcrichton @gnzlbg @jonas-schievink @bgermann