Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv isn't being compiled with optimizations #6142

Closed
thestinger opened this issue Apr 30, 2013 · 0 comments
Closed

libuv isn't being compiled with optimizations #6142

thestinger opened this issue Apr 30, 2013 · 0 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

The Makefile should be passing along CFLAGS (and possibly LDFLAGS), but currently isn't.
@thestinger thestinger mentioned this issue May 2, 2013
Merged
bors added a commit that referenced this issue May 2, 2013
@bors
auto merge of #6176 : thestinger/rust/libuv_optimize, r=thestinger
89377ea 
Closes #6142
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 24, 2020
@bors
Auto merge of rust-lang#6151 - bofh69:master, r=ebroto
2bdadd8 
Preserve raw strs for: format!(s) to s.to_string() lint

fixes rust-lang#6142

clippy::useless_format will keep the source's string (after converting {{ and }} to { and }) when suggesting a change from format!() to .to_string() usage. Ie:
|     let s = format!(r#""hello {{}}""#);
|             ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `r#""hello {}""#.to_string()`

changelog: [`useless_format`]: preserve raw string literals when no arguments to `format!()` are provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thestinger