Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#61276 #61461

Closed
rust-highfive opened this issue Jun 2, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#61276 #61461

rust-highfive opened this issue Jun 2, 2019 · 3 comments
Assignees
@eddyb @Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #61276, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @eddyb, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @petrochenkov, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2019
@petrochenkov petrochenkov mentioned this issue Jun 3, 2019
Closed
@jonas-schievink jonas-schievink mentioned this issue Jun 4, 2019
Closed
@pnkfelix
Copy link
Member

pnkfelix commented Jun 6, 2019 •
edited
Loading

triage: P-medium. Removing nomination.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jun 6, 2019
@ghost
Copy link

ghost commented Jun 6, 2019

fyi, rls built for me with latest rust:

rustc 1.37.0-dev (8b3686709 2019-06-06)
binary: rustc
commit-hash: 8b36867093fb774bcbd9f787cbc470a5f44c1310
commit-date: 2019-06-06
host: x86_64-unknown-linux-gnu
release: 1.37.0-dev
LLVM version: 8.0

-rwxr-xr-x 1 user user 506258512 06.06.2019 23:42 rls*

@mati865
Copy link
Contributor

mati865 commented Jun 7, 2019

It was fixed by #61582

@estebank estebank closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@eddyb @pnkfelix @mati865 @estebank @Xanewok @rust-highfive