Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update clippy from 20da8f45 to 71be6f62 #61582

Merged
merged 1 commit into from
Jun 6, 2019
Merged

submodules: update clippy from 20da8f45 to 71be6f62 #61582

merged 1 commit into from
Jun 6, 2019

Conversation

matthiaskrgr
Copy link
Member

Changes:

rustup https://github.com/rust-lang/rust/pull/57428/
Remove `to_string()`s from CompilerLintFunctions
Fix comment grammar
Fix .map(..).unwrap_or_else(..) bad suggestion
add suggestions for print/write with newline lint

Fixes #61578
r? @oli-obk

@matthiaskrgr
submodules: update clippy from 20da8f4 to 71be6f6
d68f0e1 
Changes:
````
rustup rust-lang#57428
Remove `to_string()`s from CompilerLintFunctions
Fix comment grammar
Fix .map(..).unwrap_or_else(..) bad suggestion
add suggestions for print/write with newline lint
````
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Jun 6, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 6, 2019

📌 Commit d68f0e1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 6, 2019
@Centril
Rollup merge of rust-lang#61582 - matthiaskrgr:submodule_upd, r=oli-obk
97a2acd 
submodules: update clippy from 20da8f4 to 71be6f6

Changes:
````
rustup rust-lang#57428
Remove `to_string()`s from CompilerLintFunctions
Fix comment grammar
Fix .map(..).unwrap_or_else(..) bad suggestion
add suggestions for print/write with newline lint
````
Fixes rust-lang#61578
r? @oli-obk
@Centril Centril mentioned this pull request Jun 6, 2019
Merged
bors added a commit that referenced this pull request Jun 6, 2019
@bors
Auto merge of #61583 - Centril:rollup-ug2cbfd, r=Centril
8b36867 
Rollup of 4 pull requests

Successful merges:

 - #61556 (librustc_errors: Rename AnnotateRs -> AnnotateSnippet)
 - #61557 (rustbuild: Include `rustfmt` in deduplicated dependencies)
 - #61571 (Escape HashMap with backticks in needs_drop docs)
 - #61582 (submodules: update clippy from 20da8f4 to 71be6f6)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jun 6, 2019

⌛ Testing commit d68f0e1 with merge 8b36867...

@bors bors merged commit d68f0e1 into rust-lang:master Jun 6, 2019
@mati865 mati865 mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#57428
4 participants
@matthiaskrgr @rust-highfive @oli-obk @bors