Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: duplicate matcher binding in macros #61481

Closed
Mark-Simulacrum opened this issue Jun 3, 2019 · 6 comments
Closed

regression: duplicate matcher binding in macros #61481

Mark-Simulacrum opened this issue Jun 3, 2019 · 6 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

root: nes - 1 detected crates which regressed due to this; cc @TrionProg

 * nes-0.1.1: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/nes-0.1.1/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/nes-0.1.1/log.txt); cc @TrionProg
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jun 3, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 3, 2019
Closed
@petrochenkov petrochenkov self-assigned this Jun 3, 2019
@petrochenkov
Copy link
Contributor

The regression is expected and was introduced in #59858.
This was a deprecation warning previously.
cc @mark-i-m

@petrochenkov petrochenkov removed their assignment Jun 3, 2019
@mark-i-m
Copy link
Member

mark-i-m commented Jun 3, 2019

This regression was fixed in TrionProg/nes#2

The crate just hasn't been updated.

@mark-i-m
Copy link
Member

mark-i-m commented Jun 3, 2019

And FWIW, it fixed a bug in that crate.

@mark-i-m
Copy link
Member

mark-i-m commented Jun 3, 2019

@Mark-Simulacrum ^^^

@Mark-Simulacrum
Copy link
Member Author

I'll leave this open for now for the compiler team to decide, but I expect that we'll simply close this as an expected regression (and perhaps the crate's author will publish a new version).

@Centril
Copy link
Contributor

Centril commented Jun 18, 2019

Closing per note in #61481 (comment). I also don't see the language team being OK with reintroducing this bug (I'm not).

@Centril Centril closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Centril @Mark-Simulacrum @petrochenkov @mark-i-m