Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.hashchange is not a function #63707

Closed
richardwhiuk opened this issue Aug 19, 2019 · 1 comment · Fixed by #63774
Closed

window.hashchange is not a function #63707

richardwhiuk opened this issue Aug 19, 2019 · 1 comment · Fixed by #63774
Assignees
@fmckeogh
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@richardwhiuk
Copy link

richardwhiuk commented Aug 19, 2019 •
edited by rustbot
Loading

When selecting Rust source code with either the latest stable or the latest nightly, the following is seen:

main-20190703-1.36.0-a53f9df32.js:1 Uncaught TypeError: window.hashchange is not a function
    at set_fragment (main-20190703-1.36.0-a53f9df32.js:1)
    at HTMLDocument.document.onclick (main-20190703-1.36.0-a53f9df32.js:1)

e.g. see https://docs.rs/ensure/0.2.1/src/ensure/lib.rs.html#11 and try and select some lines

Suspect that https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/main.js#L347 should be highlightSourceLines(null).
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 19, 2019
@fmckeogh
Copy link
Member

@rustbot claim

@fmckeogh fmckeogh mentioned this issue Aug 21, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Sep 3, 2019
@Centril
Rollup merge of rust-lang#63774 - chocol4te:fix_63707, r=GuillaumeGomez
cdc821f 
Fix `window.hashchange is not a function`

Closes rust-lang#63707.
Centril added a commit to Centril/rust that referenced this issue Sep 5, 2019
@Centril
Rollup merge of rust-lang#63774 - chocol4te:fix_63707, r=GuillaumeGomez
789d9b7 
Fix `window.hashchange is not a function`

Closes rust-lang#63707.
Centril added a commit to Centril/rust that referenced this issue Sep 5, 2019
@Centril
Rollup merge of rust-lang#63774 - chocol4te:fix_63707, r=GuillaumeGomez
e56fe69 
Fix `window.hashchange is not a function`

Closes rust-lang#63707.
@bors bors closed this as completed in 6da74a2 Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmckeogh fmckeogh

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix window.hashchange is not a function fmckeogh/rust
3 participants
@richardwhiuk @jonas-schievink @fmckeogh