Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#62727 #63729

Closed
rust-highfive opened this issue Aug 20, 2019 · 1 comment · Fixed by #63736
Closed

rls no longer builds after rust-lang/rust#62727 #63729

rust-highfive opened this issue Aug 20, 2019 · 1 comment · Fixed by #63736
Assignees
@Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #62727, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @SimonSapin, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @petrochenkov, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2019
@SimonSapin SimonSapin mentioned this issue Aug 20, 2019
Merged
@SimonSapin
Copy link
Contributor

#63736 should fix this

Centril added a commit to Centril/rust that referenced this issue Aug 20, 2019
@Centril
Rollup merge of rust-lang#63736 - SimonSapin:plugin, r=eddyb
8369edb 
Restore the rustc_plugin crate in the sysroot

It was accidentally removed in a rebase of rust-lang#62727

Fixes rust-lang#63729 (rls build failure)
Centril added a commit to Centril/rust that referenced this issue Aug 20, 2019
@Centril
Rollup merge of rust-lang#63736 - SimonSapin:plugin, r=eddyb
b2d4415 
Restore the rustc_plugin crate in the sysroot

It was accidentally removed in a rebase of rust-lang#62727

Fixes rust-lang#63729 (rls build failure)
Centril added a commit to Centril/rust that referenced this issue Aug 20, 2019
@Centril
Rollup merge of rust-lang#63736 - SimonSapin:plugin, r=eddyb
cadf6b9 
Restore the rustc_plugin crate in the sysroot

It was accidentally removed in a rebase of rust-lang#62727

Fixes rust-lang#63729 (rls build failure)
@bors bors closed this as completed in c561abe Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore the rustc_plugin crate in the sysroot SimonSapin/rust
3 participants
@SimonSapin @Xanewok @rust-highfive