Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RustDoc: remove the redundant unstable option "--linker" #63816

Closed
andjo403 opened this issue Aug 22, 2019 · 7 comments · Fixed by #63834
Closed

RustDoc: remove the redundant unstable option "--linker" #63816

andjo403 opened this issue Aug 22, 2019 · 7 comments · Fixed by #63834
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@andjo403
Copy link
Contributor

while working on #63638 i have noticed the there is a conflict between the "-C linker" and the "--linker" option where the later overrides the former.

but as the --linker flag is unstable I think that it shall be removed as is it confusing where all other "-C" options works but not the linker one.

@jonas-schievink jonas-schievink added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 22, 2019
@mati865
Copy link
Contributor

mati865 commented Aug 23, 2019

Are you sure -C linker works for rustdoc?
I thought rustdoc only cares about --linker and rustc about -C linker.

@andjo403
Copy link
Contributor Author

now rustdoc -C linker do not work but if the --linker option is removed the -C linker will work as expected

@mati865
Copy link
Contributor

mati865 commented Aug 23, 2019

if the --linker option is removed the -C linker will work as expected

I think it'd have to be implemented in rustdoc first.

@andjo403
Copy link
Contributor Author

yes that is what this issue is about remove the --linker option from rustdoc and use the -C linker option instead

@andjo403
Copy link
Contributor Author

andjo403 commented Aug 28, 2019

@petrochenkov do you know if there is some process to remove the unstable linker option from rustdoc as you added it in #45191

@petrochenkov
Copy link
Contributor

do you know if there is some process to remove the unstable linker option from rustdoc

I don't know ¯_(ツ)_/¯
If it's unstable and there's a replacement, then it can probable be just removed?
cc @rust-lang/rustdoc

@GuillaumeGomez
Copy link
Member

If it's not stable, then it's fine. :)

bors added a commit that referenced this issue Sep 2, 2019
remove the unstable rustdoc parameter --linker

use the code generation parameter -Clinker (same parameter as rustc)
to control what linker to use for building the rustdoc test executables.

closes: #63816
@bors bors closed this as completed in f0b30c7 Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants