Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

message-format=short output is unnecessarily hard to read #63835

Closed
fintelia opened this issue Aug 23, 2019 · 0 comments · Fixed by #116962
Closed

message-format=short output is unnecessarily hard to read #63835

fintelia opened this issue Aug 23, 2019 · 0 comments · Fixed by #116962
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@fintelia
Copy link
Contributor

The --message-format=short option is a very convenient way to get a condensed error output from cargo when the same/similar errors occur at many places in a code base. Unfortunately, the current output with this option uses bold/color to place the emphasis on the wrong parts of each output line, making it harder to read.

For instance, consider the screenshot below. The same "trait objects without an explicit `dyn` are deprecated" is repeated constantly, yet is bold every single time. By contrast the unique parts of each line -- the filename and line/column numbers -- are the only things that aren't bold.

Screenshot from 2019-08-23 16-45-48
@jonas-schievink jonas-schievink added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2019
@estebank estebank mentioned this issue Oct 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 20, 2023
@bors
Auto merge of rust-lang#116962 - estebank:issue-63835, r=oli-obk
f31316f 
Do not bold main message in `--error-format=short`

Fix rust-lang#63835.

Before:

<img width="484" alt="Screenshot 2023-10-19 at 3 52 53 PM" src="https://github.com/rust-lang/rust/assets/1606434/9bd6cbd5-a4ce-4cc3-8c5f-60a8d3ad38da">

After:

<img width="492" alt="Screenshot 2023-10-19 at 3 52 32 PM" src="https://github.com/rust-lang/rust/assets/1606434/0cf2417a-08f2-4074-860c-a88a838a4209">
@bors bors closed this as completed in fd49590 Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not bold main message in --error-format=short estebank/rust
2 participants
@jonas-schievink @fintelia