Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic dark theme still doesn't work #64061

Closed
fenhl opened this issue Sep 1, 2019 · 1 comment · Fixed by #64096
Closed

Automatic dark theme still doesn't work #64061

fenhl opened this issue Sep 1, 2019 · 1 comment · Fixed by #64096

Comments

@fenhl
Copy link
Contributor

fenhl commented Sep 1, 2019

Follow-up to #61079, #61236, #63830, and #63847.

Same symptoms as #63830. Additionally, I'm seeing styles from both light.css and dark.css active, and the ones in light.css are taking precedence over the ones in dark.css even though the system is in dark mode. Tested on https://doc.rust-lang.org/nightly/std/ after deleting the local storage entry, and docs generated locally.
@fenhl
Copy link
Contributor Author

fenhl commented Sep 1, 2019

cc @GuillaumeGomez

@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 2, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Sep 3, 2019
@Centril
Rollup merge of rust-lang#64096 - GuillaumeGomez:theme-regex-fix, r=M…
3e427d9 
…ark-Simulacrum

Fix regex replacement in theme detection

Fixes rust-lang#64061.

This is sadly a lot of bad luck: after making the changes and re-build the docs, I just forgot to force reload the page. Hence having the old (working) version with two replacements instead of the failing regex. Sorry again about that...

cc @fenhl
r? @Mark-Simulacrum
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 6, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#64096 - GuillaumeGomez:theme-regex-fix, r=M…
5f1acb7 
…ark-Simulacrum

Fix regex replacement in theme detection

Fixes rust-lang#64061.

This is sadly a lot of bad luck: after making the changes and re-build the docs, I just forgot to force reload the page. Hence having the old (working) version with two replacements instead of the failing regex. Sorry again about that...

cc @fenhl
r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this issue Sep 6, 2019
@Centril
Rollup merge of rust-lang#64096 - GuillaumeGomez:theme-regex-fix, r=M…
71d04f9 
…ark-Simulacrum

Fix regex replacement in theme detection

Fixes rust-lang#64061.

This is sadly a lot of bad luck: after making the changes and re-build the docs, I just forgot to force reload the page. Hence having the old (working) version with two replacements instead of the failing regex. Sorry again about that...

cc @fenhl
r? @Mark-Simulacrum
@bors bors closed this as completed in 5036237 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regex replacement in theme detection GuillaumeGomez/rust
1 participant
@fenhl