Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICEs + RUST_BACKTRACE=1 should interleave the backtrace and query stack. #70954

Open
eddyb opened this issue Apr 9, 2020 · 0 comments
Open

ICEs + RUST_BACKTRACE=1 should interleave the backtrace and query stack. #70954

eddyb opened this issue Apr 9, 2020 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Apr 9, 2020

The interleaving can be done by looking for frames with a certain function path (that we need to make sure show up w/o debuginfo, so that this is useful on nightlies).

Downside: harder to see the aggregate query stack in one place (unless we duplicate it).
Upside: easier to find where a query was invoked from.

cc @Zoxc
@eddyb eddyb added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2020
@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @JohnTitor