Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename libserialize #7098

Closed
brson opened this issue Jun 13, 2013 · 20 comments
Closed

Rename libserialize #7098

brson opened this issue Jun 13, 2013 · 20 comments
Labels
P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Jun 13, 2013

Since the types are called Encode and Decode, etc. it probably makes sense for the module to reflect this naming, maybe 'encoding' (or 'encodement' 👻 ). Yeah I argued the other way last time. Oh well.

@brson
Copy link
Contributor Author

brson commented Jun 13, 2013

@erickt What do you think?

@graydon
Copy link
Contributor

graydon commented Jun 13, 2013

I'd be fine with this if we also clustered all the concrete encodings in (say) {std, extra}::encoding::* submodules, with a few standard ones like json and xdr, and others left to extra.

(mostly for discoverability)

@graydon
Copy link
Contributor

graydon commented Jun 19, 2013

Note that if you do this, there will be some collision with the need to define character encodings. I believe this was part of the rationale for the current approach. Character encoding has (I think?) a slightly stronger precedent for use of the term than serialization encodings.

@metajack
Copy link
Contributor

metajack commented Aug 8, 2013

visiting for triage. nominating for backward compat.

@catamorphism
Copy link
Contributor

accepted for backwards-compatible

@nikomatsakis
Copy link
Contributor

I prefer encode to encoding. I guess we should have a consistent pattern for naming modules, but for some silly reason gerund module names rubs be wrong.

@brson
Copy link
Contributor Author

brson commented Sep 20, 2013

Since there's another proposed feature for encoding and decoding strings, it may be appropriate to switch back to serialization and deserialization as the terminology here.

@alexcrichton
Copy link
Member

This has moved to libserialize, updating the title

@brson
Copy link
Contributor Author

brson commented Jun 27, 2014

@erickt Do you have any new opinions on what we should do here?

@erickt
Copy link
Contributor

erickt commented Jun 27, 2014

@brson: I think using Serialize/Serializer/Deserialize/Deserializer would be easiest since that's what we've been calling these operations anyway.

@errordeveloper
Copy link
Contributor

Well, I think calling it libcodecwould nice a short. I'd keep type names as they are, it's pretty good. Let's not rename for the sake of renaming. It's only the name of the library that was in question, the insides are good, I find.

@liigo
Copy link
Contributor

liigo commented Jul 7, 2014

Libcodec, +1
On Jul 8, 2014 7:00 AM, "Ilya Dmitrichenko" notifications@github.com
wrote:

Well, I think calling it libcodecwould nice a short. I'd keep type names
as they are, it's pretty good. Let's not rename for the sake of renaming.
It's only the name of the library that was in question, the insides are
good, I find.


Reply to this email directly or view it on GitHub
#7098 (comment).

@brson
Copy link
Contributor Author

brson commented Jul 9, 2014

I would not assume that something called libcodec is a serialization library, but a media decoding library.

@brson
Copy link
Contributor Author

brson commented Jul 9, 2014

Of course the same is true of encode.

@brson brson self-assigned this Aug 1, 2014
@brson
Copy link
Contributor Author

brson commented Aug 5, 2014

@erickt If I wanted to rename the Encode/Decode types, and others containing those words, leaving the deprecated originals in place, would it be better to do it now, or wait until you've got your redesign finished?

@erickt
Copy link
Contributor

erickt commented Aug 5, 2014

I'd wait for my redesign. I've finally finished the core of my work, now I'm validating the design by porting toml/msgpack/mustache/etc over to it to validate the design. So hopefully it won't be too long until I'm ready to merge it upstream.

@brson
Copy link
Contributor Author

brson commented Sep 11, 2014

Nominating for removal from 1.0. If the naming in this lib ends up inconsistent it's not the end of the world (of Rust). The entire lib could also just be experimental for 1.0.

@brson brson removed their assignment Sep 11, 2014
@aturon
Copy link
Member

aturon commented Sep 11, 2014

FWIW, I think it is unlikely that we'll be able to stabilize this library for 1.0, despite it's importance -- especially with significant new design work coming down the pike.

@pnkfelix
Copy link
Member

removing from 1.0 milestone and reassigning as P-low.

@pnkfelix pnkfelix removed this from the 1.0 milestone Sep 18, 2014
@aturon
Copy link
Member

aturon commented Jan 17, 2015

This is no longer relevant with the move of the crate into crates.io.

@aturon aturon closed this as completed Jan 17, 2015
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 22, 2021
Add `cloned_instead_of_copied` lint

Don't go cloning all willy-nilly.

Featuring a new `get_iterator_item_ty` util!

changelog: Add cloned_instead_of_copied lint

Closes rust-lang#3870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low Low priority
Projects
None yet
Development

No branches or pull requests