Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc --print target-features doesn't print crt-static #71583

Closed
petrochenkov opened this issue Apr 26, 2020 · 4 comments · Fixed by #73346
Closed

rustc --print target-features doesn't print crt-static #71583

petrochenkov opened this issue Apr 26, 2020 · 4 comments · Fixed by #73346
Assignees
@rustbot
Labels
A-target-specs Area: compile-target specifications C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@petrochenkov
Copy link
Contributor

petrochenkov commented Apr 26, 2020 •
edited by rustbot
Loading

despite it being usable in -C target-feature.

This issue has been assigned to @ryzokuken via this comment.
@petrochenkov petrochenkov added C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 26, 2020
@csmoe csmoe added the A-target-specs Area: compile-target specifications label Apr 26, 2020
@ryzokuken
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Apr 27, 2020
@xabxx
Copy link

xabxx commented May 12, 2020

@ryzokuken hi there. Are you still working on this? :)

@ryzokuken
Copy link
Contributor

@xabxx couldn't find the time to look into this deeper, sorry. Feel free to pick it up.

@aszenz aszenz mentioned this issue Jun 14, 2020
Merged
@aszenz
Copy link
Contributor

aszenz commented Jun 14, 2020

@petrochenkov
The target features for a particular architecture are taken from llvm in llvm_util.rs line 341.

The crt-static seems to be a rust-specific target feature that is not present in llvm feature table, I think its the only one right now. I have made a basic naive pr which just prints it out since I'm hoping to get feedback for improving it

RalfJung added a commit to RalfJung/rust that referenced this issue Jun 18, 2020
@RalfJung
Rollup merge of rust-lang#73346 - aszenz:patch-1, r=cuviper
c51d0ac 
Add rust specific features to print target features

Fixes rust-lang#71583

`crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`.

Probably the most native implementation I could think of, would love to get feedback.
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 18, 2020
@Manishearth
Rollup merge of rust-lang#73346 - aszenz:patch-1, r=cuviper
8fa2f09 
Add rust specific features to print target features

Fixes rust-lang#71583

`crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`.

Probably the most native implementation I could think of, would love to get feedback.
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 19, 2020
@Manishearth
Rollup merge of rust-lang#73346 - aszenz:patch-1, r=cuviper
1dfba21 
Add rust specific features to print target features

Fixes rust-lang#71583

`crt-static` is a rust specific target feature that's absent from llvm feature table, adding it there so that it shows under `rustc --print target-features`.

Probably the most native implementation I could think of, would love to get feedback.
@bors bors closed this as completed in 8d79ebd Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-target-specs Area: compile-target specifications C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rust specific features to print target features aszenz/rust
6 participants
@petrochenkov @ryzokuken @aszenz @xabxx @csmoe @rustbot