Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename #[no_drop_flag] to #[unsafe_no_drop_flag] #7428

Closed
thestinger opened this issue Jun 27, 2013 · 1 comment
Closed

rename #[no_drop_flag] to #[unsafe_no_drop_flag] #7428

thestinger opened this issue Jun 27, 2013 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@thestinger
Copy link
Contributor

Since it zeroes the whole struct regardless of the contained types, it's not safe. The fields can be accessed by safe code in the destructor. This is working as intended, but it should be more clear.
@poiru poiru mentioned this issue Jun 27, 2013
Closed
@thestinger
Copy link
Contributor Author

This is merged.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 15, 2021
@bors
Auto merge of rust-lang#7428 - camsteffen:use-self-ice, r=flip1995
0a59c24 
Fix use_self ICE

changelog: Fix ICE rust-lang#7423

r? `@flip1995`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename #[no_drop_flag] to #[unsafe_no_drop_flag] poiru/rust
1 participant
@thestinger